melanie witt 72a2477ec0 Fix 'server event list|show' for deleted servers
As of compute microversion >= 2.21, support for list and show of server
events for deleted servers was added. This however wasn't working using
the openstackclient because the compute GET /servers/{server_id} will
not return a deleted server, so osc_lib.utils.find_resource() fails to
find the server and the command bails early.

This adds a check for a uuid-like <server> arg and uses it directly if
the <server> cannot be found via find_resource().

A note is also added to the command help to indicate that list and show
for deleted servers will only work if a server ID is passed (name will
not work).

Story: 2009841
Task: 44443

Change-Id: Icd33b3b9a3a1855d7893dd111bbb2aca059f45fd
2022-02-09 23:26:25 +00:00

120 lines
5.2 KiB
Python

# Copyright 2017 Huawei, Inc. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
import json
from openstackclient.tests.functional.compute.v2 import common
class ServerEventTests(common.ComputeTestCase):
"""Functional tests for server event"""
def setUp(self):
super(ServerEventTests, self).setUp()
# NOTE(dtroyer): As long as these tests are read-only we can get away
# with using the same server instance for all of them.
cmd_output = self.server_create()
self.server_id = cmd_output.get('id')
self.server_name = cmd_output['name']
def test_server_event_list_and_show(self):
"""Test list, show server event"""
# Test 'server event list' for creating
cmd_output = json.loads(self.openstack(
'server event list -f json ' + self.server_name
))
request_id = None
for each_event in cmd_output:
self.assertNotIn('Message', each_event)
self.assertNotIn('Project ID', each_event)
self.assertNotIn('User ID', each_event)
if each_event.get('Action') == 'create':
self.assertEqual(self.server_id, each_event.get('Server ID'))
request_id = each_event.get('Request ID')
break
self.assertIsNotNone(request_id)
# Test 'server event show' for creating
cmd_output = json.loads(self.openstack(
'server event show -f json ' + self.server_name + ' ' + request_id
))
self.assertEqual(self.server_id, cmd_output.get('instance_uuid'))
self.assertEqual(request_id, cmd_output.get('request_id'))
self.assertEqual('create', cmd_output.get('action'))
self.assertIsNotNone(cmd_output.get('events'))
self.assertIsInstance(cmd_output.get('events'), list)
# Reboot server, trigger reboot event
self.openstack('server reboot --wait ' + self.server_name)
# Test 'server event list --long' for rebooting
cmd_output = json.loads(self.openstack(
'server event list --long -f json ' + self.server_name
))
request_id = None
for each_event in cmd_output:
self.assertIn('Message', each_event)
self.assertIn('Project ID', each_event)
self.assertIn('User ID', each_event)
if each_event.get('Action') == 'reboot':
request_id = each_event.get('Request ID')
self.assertEqual(self.server_id, each_event.get('Server ID'))
break
self.assertIsNotNone(request_id)
# Test 'server event show' for rebooting
cmd_output = json.loads(self.openstack(
'server event show -f json ' + self.server_name + ' ' + request_id
))
self.assertEqual(self.server_id, cmd_output.get('instance_uuid'))
self.assertEqual(request_id, cmd_output.get('request_id'))
self.assertEqual('reboot', cmd_output.get('action'))
self.assertIsNotNone(cmd_output.get('events'))
self.assertIsInstance(cmd_output.get('events'), list)
def test_server_event_list_and_show_deleted_server(self):
# Need to create a new server that will not attempt cleanup because we
# are going to delete it during the test and cleanup would fail with
# 404.
cmd_output = self.server_create(cleanup=False)
server_id = cmd_output['id']
# Delete the server
self.openstack('server delete --wait ' + server_id)
# And verify we can get the event list after it's deleted
# Test 'server event list' for deleting
cmd_output = json.loads(self.openstack(
'--os-compute-api-version 2.21 '
'server event list -f json ' + server_id
))
request_id = None
for each_event in cmd_output:
self.assertNotIn('Message', each_event)
self.assertNotIn('Project ID', each_event)
self.assertNotIn('User ID', each_event)
if each_event.get('Action') == 'delete':
self.assertEqual(server_id, each_event.get('Server ID'))
request_id = each_event.get('Request ID')
break
self.assertIsNotNone(request_id)
# Test 'server event show' for deleting
cmd_output = json.loads(self.openstack(
'--os-compute-api-version 2.21 '
'server event show -f json ' + server_id + ' ' + request_id
))
self.assertEqual(server_id, cmd_output.get('instance_uuid'))
self.assertEqual(request_id, cmd_output.get('request_id'))
self.assertEqual('delete', cmd_output.get('action'))
self.assertIsNotNone(cmd_output.get('events'))
self.assertIsInstance(cmd_output.get('events'), list)