openstack/python-saharaclient
Code Issues Proposed changes

Adding sahara_url and endpoint_type to OpenstackClient CLI

Browse Source 
Adding ability to specify Data processing API url and
endpoint type that will be used by OpenstackClient CLI

Change-Id: I72d9b3f051b8d7b144e2f762be45f11080246222
Partially implements: blueprint cli-as-openstackclient-plugin
This commit is contained in:
Andrey Pavlov
2015-09-07 13:30:41 +03:00
parent 991d7ae20f
commit 248767ef63
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
saharaclient/osc/plugin.py
View File

@@ -34,11 +34,15 @@ def make_client(instance):
LOG.debug('Instantiating data-processing client: %s',
data_processing_client)
kwargs = utils.build_kwargs_dict('endpoint_type', instance._interface)
client = data_processing_client(
session=instance.session,
region_name=instance._region_name,
cacert=instance._cacert,
insecure=instance._insecure
insecure=instance._insecure,
sahara_url=instance._cli_options.data_processing_url,
**kwargs
)
return client
@@ -54,4 +58,10 @@ def build_option_parser(parser):
help=("Data processing API version, default=" +
DEFAULT_DATA_PROCESSING_API_VERSION +
' (Env: OS_DATA_PROCESSING_API_VERSION)'))
parser.add_argument(
"--os-data-processing-url",
default=utils.env(
"OS_DATA_PROCESSING_URL"),
help=("Data processing API URL, "
"(Env: OS_DATA_PROCESSING_API_URL)"))
return parser

6
saharaclient/tests/unit/osc/test_plugin.py
View File

@@ -30,9 +30,13 @@ class TestDataProcessingPlugin(base.BaseTestCase):
instance._region_name = 'region_name'
instance._cacert = 'cacert'
instance._insecure = 'insecure'
instance._cli_options.data_processing_url = 'url'
instance._interface = 'public'
plugin.make_client(instance)
p_client.assert_called_with(session='session',
region_name='region_name',
cacert='cacert',
insecure='insecure')
insecure='insecure',
sahara_url='url',
endpoint_type='public')