openstack/python-swiftclient
Code Issues Proposed changes

Fix test_raw_upload test

Browse Source 
We were testing the test but we were not testing that we have actually
properly uploaded the object with the right content-len

(and it was broken under py3)

Change-Id: Ifa91c30532090cac9f8e18ff18eaf5e6c98737d1
This commit is contained in:
Chmouel Boudjnah 2014-04-15 16:43:25 -04:00
parent 504e5a7f53
commit e2b7636d66
1 changed files with 11 additions and 5 deletions

16
tests/test_swiftclient.py

@ -679,19 +679,25 @@ class TestPutObject(MockHttpTest):
resp = MockHttpResponse(status=200)
conn[1].getresponse = resp.fake_response
conn[1]._request = resp._fake_request
mock_file = StringIO.StringIO('asdf')
astring = 'asdf'
astring_len = len(astring)
mock_file = StringIO.StringIO(astring)
c.put_object(url='http://www.test.com', http_conn=conn,
contents=mock_file, content_length=4)
contents=mock_file, content_length=astring_len)
self.assertTrue(isinstance(resp.requests_params['data'],
swiftclient.utils.LengthWrapper))
self.assertEqual(mock_file.len, 4)
self.assertEqual(astring_len,
len(resp.requests_params['data'].read()))
mock_file = StringIO.StringIO(astring)
c.put_object(url='http://www.test.com', http_conn=conn,
headers={'Content-Length': '4'}, contents=mock_file)
headers={'Content-Length': str(astring_len)},
contents=mock_file)
self.assertTrue(isinstance(resp.requests_params['data'],
swiftclient.utils.LengthWrapper))
self.assertEqual(mock_file.len, 4)
self.assertEqual(astring_len,
len(resp.requests_params['data'].read()))
def test_chunk_upload(self):
# Chunked upload happens when no content_length is passed to put_object