openstack/python-tackerclient
Code Issues Proposed changes

Update patch set 4

Browse Source 
Patch Set 4:

(4 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 33455 \u003c33455@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_25701\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 25701 \u003c25701@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_25701\u003e replied on the change"}
This commit is contained in:
Gerrit User 25701
2023-02-15 18:58:58 +00:00
committed by Gerrit Code Review
parent 464a55fd5d
commit 2d6f00a793
1 changed files with 90 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

90
fa0e86837cb79dc823a6ef3d58f73ff556d6cd10
View File

@@ -47,6 +47,30 @@
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ce8ec2af_348e6049",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 7,
"author": {
"id": 25701
},
"writtenOn": "2023-02-15T18:58:58Z",
"side": 1,
"message": "Why don\u0027t you simply drop \"Support\" instead?",
"parentUuid": "eb383ea8_e9f7c249",
"range": {
"startLine": 7,
"startChar": 8,
"endLine": 7,
"endChar": 13
},
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@@ -82,6 +106,24 @@
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "414dec01_f59625fe",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 11,
"author": {
"id": 25701
},
"writtenOn": "2023-02-15T18:58:58Z",
"side": 1,
"message": "Ack",
"parentUuid": "3a8e5aa7_5d4ca09b",
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@@ -221,6 +263,30 @@
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ada0eabd_e2593c9e",
"filename": "tackerclient/tacker/v1_0/nfvo/vim_utils.py",
"patchSetId": 4
},
"lineNbr": 101,
"author": {
"id": 25701
},
"writtenOn": "2023-02-15T18:58:58Z",
"side": 1,
"message": "Umm, using pop() doesn\u0027t have any means because `config_param` is not referred from anywhere again after returned from the function in all places calling it, so it\u0027s the same as without pop() actually. Only `vim` is the interested variable after that. However, I agree with your alternative for now.\n\nI\u0027d suggest one more, add a TODO for reminding that pop() is required in the function actually.",
"parentUuid": "41fab1dd_0dfdef4f",
"range": {
"startLine": 99,
"startChar": 4,
"endLine": 101,
"endChar": 28
},
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@@ -315,6 +381,30 @@
},
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cbc8a530_2732f5b2",
"filename": "tackerclient/tests/unit/vm/test_vim_utils.py",
"patchSetId": 4
},
"lineNbr": 60,
"author": {
"id": 25701
},
"writtenOn": "2023-02-15T18:58:58Z",
"side": 1,
"message": "Ack",
"parentUuid": "1166ffe0_e4b9a576",
"range": {
"startLine": 57,
"startChar": 8,
"endLine": 60,
"endChar": 30
},
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}