openstack/python-tripleoclient
Code Issues Proposed changes

Stop configuring install_command in tox.

Browse Source 
Currently, we are overriding 'install_command' to use 'pip'. This is
considered poor behavior and 'python -m pip' should be used instead:

https://snarky.ca/why-you-should-use-python-m-pip/

It turns out that this is the the default value provided by tox:

https://tox.readthedocs.io/en/latest/config.html#conf-install_command

So we can remove the line and simply use the default value. This change
showed we needed a newer version of requests in lower constraints,
aliging with the version required by tripleo-common. This change showed
we needed a newer version of openstacksdk in lower constraints, aliging
with the version required by metalsmith. This change showed we needed a
newer version of keystoneauth1 in lower constraints, aliging with the
version required by openstacksdk. This change showed we needed a newer
version of decorator in lower constraints, aliging with the version
required by openstacksdk. This change showed we needed a newer version
of dogpile.cache in lower constraints, aliging with version required by
openstacksdk.

Change-Id: I4668fe763239a8c6380e82e64d5c9aa0657bb628
This commit is contained in:
Daniel Bengtsson 2019-11-08 09:51:44 +01:00
parent dad628fb97
commit 6bdf6f3fe9
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tox.ini
View File

@ -11,7 +11,6 @@ ignore_basepython_conflict = True
[testenv]
basepython = python3
usedevelop = True
install_command = pip install -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master} {opts} {packages}
passenv =
LANG
LANGUAGE