openstack
/
python-tripleoclient
Code Issues Proposed changes

tripleo_deploy: symlink ansible-playbook 

In RHEL8, we'll have /usr/bin/ansible-playbook provided by ansible
package.
Everywhere in TripleO we rely on /usr/bin/ansible-playbook but the
ansible-python3 package in Fedora 28 doesn't provide it.
Until it does, we have a temporary workaround that will create a symlink
only if the file doesn't exist and if ansible-playbook3 is here.

Change-Id: I040345ffb76a14035e6100c4e61a9aea07b690c6
Related-Bug: #1812837
This commit is contained in:
Emilien Macchi 2019-01-23 10:25:31 -05:00
parent 034edf0c93
commit 9e500285f0
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tripleoclient/v1/tripleo_deploy.py
View File

@ -106,6 +106,18 @@ class Deploy(command.Command):
ansible_playbook_cmd = "ansible-playbook-{}".format(python_version)
python_cmd = "python{}".format(python_version)
# https://bugs.launchpad.net/tripleo/+bug/1812837
if not os.path.exists('/usr/bin/ansible-playbook'):
if os.path.exists('/usr/bin/' + ansible_playbook_cmd):
if not os.path.exists('/usr/local/bin/ansible-playbook'):
os.symlink('/usr/bin/' + ansible_playbook_cmd,
'/usr/local/bin/ansible-playbook')
else:
if not os.path.exists('/usr/bin/' + ansible_playbook_cmd):
if not os.path.exists('/usr/local/bin/' + ansible_playbook_cmd):
os.symlink('/usr/bin/ansible-playbook',
'/usr/local/bin/' + ansible_playbook_cmd)
def _is_undercloud_deploy(self, parsed_args):
return parsed_args.standalone_role == 'Undercloud' and \
parsed_args.stack == 'undercloud'