openstack/python-tripleoclient
Code Issues Proposed changes

Remove unused option enable_container_images_build

Browse Source 
This option was added in change
I5cf5798cd084d99a3c892daab6db444d1e608beb but was never actually wired
in to do anything.

Since we now have such comprehensive image build pipelines, I think it
is better to removed this unused option rather than wire it in.

Change-Id: I20f67d8b1bbeb8b768777a41b5d33c819192ea2d
This commit is contained in:
Steve Baker 2018-05-15 09:21:11 +12:00
parent 58a15b557e
commit daf94b006f
2 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tripleoclient/config/undercloud.py
View File

@ -248,12 +248,6 @@ class UndercloudConfig(StandaloneConfig):
'install. This is a no-op for containerized ' 'install. This is a no-op for containerized '
'undercloud.') 'undercloud.')
), ),
cfg.BoolOpt('enable_container_images_build',
default=True,
help=_(
'Whether to enable docker container images to be '
'build on the undercloud.')
),
cfg.StrOpt('ipa_otp', cfg.StrOpt('ipa_otp',
default='', default='',
help=_( help=_(

2
tripleoclient/tests/config/test_config_undercloud.py
View File

@ -34,7 +34,6 @@ class TestUndercloudConfig(base.TestCase):
'discovery_default_driver', 'discovery_default_driver',
'docker_insecure_registries', 'docker_insecure_registries',
'docker_registry_mirror', 'docker_registry_mirror',
'enable_container_images_build',
'enable_node_discovery', 'enable_node_discovery',
'enable_routed_networks', 'enable_routed_networks',
'enable_swift_encryption', 'enable_swift_encryption',
@ -83,7 +82,6 @@ class TestUndercloudConfig(base.TestCase):
'docker_insecure_registries', 'docker_insecure_registries',
'docker_registry_mirror', 'docker_registry_mirror',
'enable_cinder', 'enable_cinder',
'enable_container_images_build',
'enable_ironic', 'enable_ironic',
'enable_ironic_inspector', 'enable_ironic_inspector',
'enable_mistral', 'enable_mistral',