openstack
/
python-tripleoclient
Code Issues Proposed changes

Fix message of unused_params and invalid_role_specific_params. 

Fix message of unused_params and invalid_role_specific_params in
workflows parameters file. Display parameters name not a data structure.

Change-Id: I21b550a0106fc9cc582b63eb2c74e46ad5ca6065
Closes-Bug: #1838956
Depends-On: https://review.opendev.org/#/c/674327
This commit is contained in:
Natal Ngétal 2019-08-05 12:28:26 +02:00
parent d31fbf2e4c
commit eb5971ca41
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
tripleoclient/workflows/parameters.py
View File

@ -86,18 +86,23 @@ def check_deprecated_parameters(clients, container):
) )
messages = base.wait_for_messages(workflow_client, ws, execution, 120) messages = base.wait_for_messages(workflow_client, ws, execution, 120)
has_messages = False
deprecated_params = []
unused_params = []
invalid_role_specific_params = []
for message in messages: for message in messages:
if message['status'] == 'SUCCESS': if message['status'] != 'SUCCESS':
for param in message.get('deprecated', []): return
if param.get('user_defined'):
deprecated_params.append(param['parameter']) has_messages = True
unused_params = message.get('unused', []) deprecated_params = [
invalid_role_specific_params = message.get( param['parameter'] for param in message.get('deprecated', [])
'invalid_role_specific', []) if param.get('user_defined')
]
unused_params = message.get('unused', [])
invalid_role_specific_params = message.get(
'invalid_role_specific', [])
if not has_messages:
return
if deprecated_params: if deprecated_params:
deprecated_join = ', '.join( deprecated_join = ', '.join(