openstack
/
python-troveclient
Code Issues Proposed changes

Change assertTrue(isinstance()) by optimal assert 

Some of tests use different method of assertTrue(isinstance(A, B)),
The correct way is to use assertIsInstance(A,B) provided by testtools

Closes-bug: #1268480
Change-Id: I718b86e83b93a4e778710b9de895f2796a9b6d61
This commit is contained in:
yangyapeng 2016-01-04 17:31:58 -05:00 committed by Craig Vyvial
parent 5a22620144
commit 6b02886348
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
troveclient/tests/test_accounts.py
View File

@ -77,7 +77,7 @@ class AccountsTest(testtools.TestCase):
self.accounts.api.client.get = mock.Mock(return_value=(resp, body))
self.assertRaises(Exception, self.accounts.index)
resp.status_code = 200
self.assertTrue(isinstance(self.accounts.index(), base.Resource))
self.assertIsInstance(self.accounts.index(), base.Resource)
self.accounts.api.client.get = mock.Mock(return_value=(resp, None))
self.assertRaises(Exception, self.accounts.index)

4
troveclient/tests/test_base.py
View File

@ -293,7 +293,7 @@ class MangerPaginationTests(ManagerTest):
self.assertEqual('p2', resp.items[1].foo)
self.assertEqual(self.marker, resp.next)
self.assertEqual(self.links, resp.links)
self.assertTrue(isinstance(resp, common.Paginated))
self.assertIsInstance(resp, common.Paginated)
def test_pagination_next(self):
resp = self.manager._paginated(self.url, self.response_key,
@ -303,7 +303,7 @@ class MangerPaginationTests(ManagerTest):
self.assertEqual('p4', resp.items[1].foo)
self.assertEqual(None, resp.next)
self.assertEqual([], resp.links)
self.assertTrue(isinstance(resp, common.Paginated))
self.assertIsInstance(resp, common.Paginated)
def test_pagination_error(self):
self.manager.api.client.get = mock.Mock(return_value=(None, None))

2
troveclient/tests/test_management.py
View File

@ -94,7 +94,7 @@ class ManagementTest(testtools.TestCase):
self.management.api.client.get = mock.Mock(return_value=('resp', body))
management.RootHistory.__init__ = mock.Mock(return_value=None)
rh = self.management.root_enabled_history("instance")
self.assertTrue(isinstance(rh, management.RootHistory))
self.assertIsInstance(rh, management.RootHistory)
def test__action(self):
resp = mock.Mock()