As part of the first community-wide goal [1], teams were asked
to remove the openstack/common package of their projects
if one existed. This was a byproduct of the old oslo-incubator
form of syncing common functionality.
The package, apiclient, was moved to a top level location
and cliutils was moved to the common module. There are no oslo
specific libraries, the recommended solution is to move it
in tree and maintain it there.
Specifically in this patch, I also rearranged some of the
imports to make them match up with the hacking guidelines
while I was re-ordering them for the refactor anyway.
Lastly, the apiclient/fake_client.py was deleted since it
was not used.
[1] http://governance.openstack.org/goals/ocata/remove-incubated-oslo-code.html
Change-Id: Ib7b691240b819c9c91b100ca47ffaba75b281c78
Use xx = [] for the parameter for function, this parameter will
only be initialized at the first call, this is should be avoided.
Better choice is to set the initial value to None, then the initialization
time use xx= xx or []
more information:http://effbot.org/zone/default-values.htm
Change-Id: Icbade7dd4c7d231ae65fd4f8de673b484bab721c
Help, print, and exception messages will now all be translated. I
did not find any logging messages.
Motivation for this change:
1. A patch for shell.py recently added i18n, we should be
consistent with the additions from v1.
2. I noticed a patch on v1/shell.py that had reviewers suggesting
to use i18n, instead of applying it to one message lets do it
for the whole file.
Change-Id: Ifd1bf25020c5f180a074165e2634a105bcbd4ed8
Releasenote translation publishing is being prepared. 'locale_dirs'
needs to be defined in conf.py to generate translated version of the
release notes.
Note that this repository might not get translated release notes - or
no translations at all - but we add the entry here nevertheless to
prepare for it.
Change-Id: I6af6b4e92f0953f673ea1a5c0f2162662cb14584
Following OpenStack Style Guidelines[1]:
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNotNone(...) is preferred
over assertNotEqual(None, ...) and assertIsNot(None, ...)
[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
Change-Id: Ie2631ce6d5f1756fe520850be0e0d304f41ba760
When trying to create an instance of size 0 an error is thrown
stating that the size was not specified, this is not correct
because I did specify it. The problem is that args.size evaluates
to False because size is 0.
This patch checks for size being zero instead and throws the correct
error message.
Change-Id: If00e83ccd919429dcfac7621dbbd9daa49f8b416
Use xx = [] for the parameter initial value, this parameter will
only be initialized at the first call, this is should be avoided.
Better choice is to set the initial value to None, then the initialization
time use xx= xx or []
more information:http://effbot.org/zone/default-values.htm
Change-Id: Ia89b9741731c07d8bf08691a1c6544742625cad6
I see us at the time of testing flavor without the "m1.medium" and
"eph.rd-smaller", I think we can add these two get test, to ensure
that the complete test.
Change-Id: Idc119e51b8dab5efb0da5dea3d0238430585e413
With https://review.openstack.org/#/c/343927/ merge,
We have two new commands are reset-status and the force-delete, but
the existing readme and there is not have this two commands,Look this
readme shows that some out of date, so need to be updated
Change-Id: Idde08fd0ae2e42dab209d38bc0225683c5fa1922
Help msg and output should support,This can be beneficial to
the string type
Partial-Bug: #1379001
Change-Id: I7d12aead49f5771f0762533ce9f53e477367101c
In order to support automatically updating the release notes when we
create stable branches, we want the pages to be in a standard order.
This patch updates the order to be reverse chronological, so the most
recent notes appear at the top.
Change-Id: Id5b7f4216a9a55249601827896703a6c87991eba
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Oslo provides a function, to_slug() in strutils that is substantially
similar to slugify() provided in utils by python-troveclient. Remove
slugify() and use to_slug() instead.
Change-Id: I97bc7cfc2c0e7d14e7617037bff431cdc1eee50f
Closes-Bug: #1266127
Author: Christian Berendt <berendt@b1-systems.de>
There exists a method in the management API to change the quota
for a given resource. This change exposes that API via a new
"trove quota-update" command. Also, adds v1.Quotas to the python
client.
Note that this command requires admin privileges.
Partial implements: blueprint bp/quota-management
Change-Id: I6ca1a87fbc46781f83bc9b7bd33745783b8aaab1
Added --incremental flag to backup-create and set the default
value to False. When the flag is passed it will create a
backup based on the last good known full/incremental backup.
If there is no previous backup a full backup will be created.
Change-Id: I96498180890b8b1692b1bac3b19988532f6eb077
Partial-Bug: #1607429
Client side of being able to specify 'priority' modules plus a
way to rank the order in which modules are applied. Two new
attributes 'priority_apply' and 'apply_order' have been added
to the python API and are supported in the CLI by means of the
module-create and module-update commands.
Partially Implements: blueprint module-management-ordering
Change-Id: I2b871c7d1eab634174396bd0905329f3a66755f6
Sometimes an instance/cluster can be stuck in BUILD state forever.
Attempting to delete the instance in this state is currently not
allowed. Add force-delete and reset-status command. Reset-status
will reset the status to ERROR, letting the instance/cluster be
deleted. Force-delete will combine functionality of reset-status
and delete.
Change-Id: I957b4be5030e493e0eb8c6b6855d41b942b2823c
Partial-Bug: #1579141
This change includes a new "trove upgrade" CLI command and
a new "Instances.upgrade" python API method to implement
the new Instance Upgrade feature.
Change-Id: I6ec2ebb78019c014f87ba5d8cbfd284686c64f30
Implements: blueprint image-upgrade
In writing the scenario tests for the fix for
https://launchpad.net/bugs/1611525 (see
https://review.openstack.org/#/c/353118/ ) it became evident that the
--all_datastores and --all_datastore_versions options weren't
functioning correctly. These options are now handled in the right way.
Change-Id: I0f226f09db08f635c542b27d8d2f898050d327fa
Partial-Bug: #1612430
