Update patch set 4
Patch Set 4: (2 comments) Patch-set: 4 Label: Verified=0
This commit is contained in:
parent
4092eacfb2
commit
999f5e3420
|
@ -23,6 +23,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_ce9fccb1",
|
||||
"filename": "qinling/api/controllers/v1/execution.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 86,
|
||||
"author": {
|
||||
"id": 16006
|
||||
},
|
||||
"writtenOn": "2019-08-06T13:23:24Z",
|
||||
"side": 1,
|
||||
"message": "You\u0027re right but it didn\u0027t seem to work as expected.\nI found why, \u0027version\u0027 should be \u0027function_version\u0027[1].\n\nhttps://github.com/openstack/qinling/blob/master/qinling/utils/executions.py#L83",
|
||||
"parentUuid": "7faddb67_bc6df503",
|
||||
"range": {
|
||||
"startLine": 71,
|
||||
"startChar": 0,
|
||||
"endLine": 86,
|
||||
"endChar": 75
|
||||
},
|
||||
"revId": "b4666c3b9c753f1486b50cd30e2168b2bf8f22d7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_7c73fde7",
|
||||
|
@ -46,6 +70,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_0ebe44ad",
|
||||
"filename": "qinling/db/sqlalchemy/models.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 55,
|
||||
"author": {
|
||||
"id": 16006
|
||||
},
|
||||
"writtenOn": "2019-08-06T13:23:24Z",
|
||||
"side": 1,
|
||||
"message": "I understand your point but I think it could be useful to know how the execution has been triggered for debug reasons for example.\n\nIf someone in their code forget to update the alias and trigger the execution with a deprecated function version then it will be simplest to track it.",
|
||||
"parentUuid": "7faddb67_7c73fde7",
|
||||
"range": {
|
||||
"startLine": 55,
|
||||
"startChar": 4,
|
||||
"endLine": 55,
|
||||
"endChar": 18
|
||||
},
|
||||
"revId": "b4666c3b9c753f1486b50cd30e2168b2bf8f22d7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_dc4d519a",
|
||||
|
|
Loading…
Reference in New Issue