openstack/rally
Code Issues Proposed changes

Fix for the deprecated library function

Browse Source 
os.popen() is deprecated since version 2.6. Resolved with use of
subprocess module.

Change-Id: I11f6dcf16a16fa5c6d9d813d1e671ea6bca991f1
This commit is contained in:
Yatin Kumbhare 2016-01-04 19:58:22 +05:30
parent 486bece8a4
commit 106138cac4
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/source/conf.py
View File

@ -13,6 +13,7 @@
import datetime
import os
import subprocess
import sys
import rally.common.version
@ -153,8 +154,10 @@ html_static_path = []
# If not "", a "Last updated on:" timestamp is inserted at every page bottom,
# using the given strftime format.
git_cmd = "git log --pretty=format:'%ad, commit %h' --date=local -n1"
html_last_updated_fmt = os.popen(git_cmd).read()
git_cmd = ["git", "log", "--pretty=format:'%ad, commit %h'", "--date=local",
"-n1"]
html_last_updated_fmt = subprocess.Popen(git_cmd,
stdout=subprocess.PIPE).communicate()[0]
# If true, SmartyPants will be used to convert quotes and dashes to
# typographically correct entities.