openstack/rally
Code Issues Proposed changes

Merge "Use assertTrue/False instead of assertEqual(T/F)"

Browse Source
This commit is contained in:
Jenkins 2016-01-19 00:24:45 +00:00 committed by Gerrit Code Review
commit 3126a466bd
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/unit/plugins/openstack/context/manila/test_manila_share_networks.py
View File

@ -74,7 +74,7 @@ class ManilaSampleGeneratorTestCase(test.TestCase):
inst.config)
self.assertIn(
rally_consts.JSON_SCHEMA, inst.CONFIG_SCHEMA.get("$schema"))
self.assertEqual(False, inst.CONFIG_SCHEMA.get("additionalProperties"))
self.assertFalse(inst.CONFIG_SCHEMA.get("additionalProperties"))
self.assertEqual("object", inst.CONFIG_SCHEMA.get("type"))
props = inst.CONFIG_SCHEMA.get("properties", {})
self.assertEqual({"type": "object"}, props.get("share_networks"))

4
tests/unit/plugins/openstack/context/sahara/test_sahara_image.py
View File

@ -145,10 +145,10 @@ class SaharaImageTestCase(test.ScenarioTestCase):
sahara_ctx.context["tenants"][tenant_id]["sahara"]["image"])
self.assertEqual("some_id", image_id)
self.assertEqual(False, mock_glance_scenario__create_image.called)
self.assertFalse(mock_glance_scenario__create_image.called)
sahara_ctx.cleanup()
self.assertEqual(False, mock_cleanup.called)
self.assertFalse(mock_cleanup.called)
@mock.patch("%s.osclients.Glance.create_client" % CTX)
def test_check_existing_image(self, mock_glance_create_client):