openstack/rally
Code Issues Proposed changes

[Verify] Deprecating 'tests-file' and 'xfails-file' args

Browse Source 
This patch deprecates the following args for `rally verify start` cmd:

     Old           New
 tests-file  -> load-list
 xfails-file -> xfail-list

So now we have consistent args that allow us to manage the workflow for
a certain list of tests:

 1. Arg 'load-list' - Run tests listed in the named file
 2. Arg 'skip-list' - Skip run of tests listed in the named file
 3. Arg 'xfail-list' - Consider tests listed in the named file as
                       expected failures

Change-Id: Ida1252172c7edf7e7dd5350123a52c085867ba0f
This commit is contained in:
Yaroslav Lobankov 2016-08-09 12:04:43 +03:00
parent 8df3e671b2
commit 423740ae9f
2 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
etc/rally.bash_completion
View File

@ -59,7 +59,7 @@ _rally()
OPTS["verify_results"]="--uuid --html --json --output-file"
OPTS["verify_show"]="--uuid --sort-by --detailed"
OPTS["verify_showconfig"]="--deployment"
OPTS["verify_start"]="--deployment --set --regex --tests-file --skip-list --tempest-config --xfails-file --no-use --system-wide --concurrency --failing"
OPTS["verify_start"]="--deployment --set --regex --load-list --skip-list --tempest-config --xfail-list --no-use --system-wide --concurrency --failing"
OPTS["verify_uninstall"]="--deployment"
OPTS["verify_uninstallplugin"]="--deployment --repo-name --system-wide"
OPTS["verify_use"]="--uuid"

23
rally/cli/commands/verify.py
View File

@ -52,25 +52,34 @@ class VerifyCommands(object):
"Available sets are %s" % ", ".join(AVAILABLE_SETS))
@cliutils.args("--regex", dest="regex", type=str, required=False,
help="Test name regular expression")
@cliutils.args("--tests-file", metavar="<path>", dest="tests_file",
@cliutils.args("--load-list", metavar="<path>", dest="tests_file",
type=str, required=False,
help="Path to a file with a list of Tempest tests "
"to run them")
"to run only them")
@cliutils.deprecated_args("--tests-file", metavar="<path>",
dest="tests_file", type=str, required=False,
help="Path to a file with a list of Tempest "
"tests to run only them", release="0.6.0")
@cliutils.args("--skip-list", metavar="<path>", dest="tests_file_to_skip",
type=str, required=False,
help="Path to a file with a list of Tempest tests "
"to skip them")
"to skip their run")
@cliutils.args("--tempest-config", dest="tempest_config", type=str,
required=False, metavar="<path>",
help="User-specified Tempest config file location")
@cliutils.args("--xfails-file", dest="xfails_file", type=str,
@cliutils.args("--xfail-list", dest="xfails_file", type=str,
required=False, metavar="<path>",
help="Path to a YAML file with a list of Tempest tests "
"that are expected to fail")
@cliutils.deprecated_args("--xfails-file", dest="xfails_file", type=str,
required=False, metavar="<path>",
help="Path to a YAML file with a list of Tempest"
" tests that are expected to fail",
release="0.6.0")
@cliutils.args("--no-use", action="store_false", dest="do_use",
help="Don't set the task as default for future operations")
help="Not to set the task as default for future operations")
@cliutils.args("--system-wide", dest="system_wide",
help="Don't create a virtual env when installing Tempest; "
help="Not to create a virtual env when installing Tempest; "
"use the local env instead of the Tempest virtual env "
"when running the tests. Note that all Tempest "
"requirements have to be already installed in "
@ -175,7 +184,7 @@ class VerifyCommands(object):
"Note, Tempest log file needs to be in subunit format")
@cliutils.args("--no-use", action="store_false", dest="do_use",
required=False,
help="Don't set new task as default for future operations")
help="Not to set new task as default for future operations")
@cliutils.alias("import")
@envutils.with_default_deployment(cli_arg_name="deployment")
def import_results(self, deployment=None, set_name="", log_file=None,