openstack/rally
Code Issues Proposed changes

[verify] Extend rerun cmd with detailed and no-use args

Browse Source 
CLI method rerun should look as similar as `rally verify start`

Change-Id: I8489b2abb48f581eea80fcdc5849cc00b4545ba1
This commit is contained in:
Andrey Kurilin 2017-03-14 20:07:28 +02:00
parent 31394284f5
commit 5a465f9057
2 changed files with 28 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
etc/rally.bash_completion
View File

@ -55,7 +55,7 @@ _rally()
OPTS["verify_list-verifier-tests"]="--id --pattern"
OPTS["verify_list-verifiers"]="--status"
OPTS["verify_report"]="--uuid --type --to --open"
OPTS["verify_rerun"]="--uuid --deployment-id --failed"
OPTS["verify_rerun"]="--uuid --deployment-id --failed --detailed --no-use"
OPTS["verify_show"]="--uuid --sort-by --detailed"
OPTS["verify_show-verifier"]="--id"
OPTS["verify_start"]="--id --deployment-id --tag --pattern --concurrency --load-list --skip-list --xfail-list --detailed --no-use"

37
rally/cli/commands/verify.py
View File

@ -379,6 +379,16 @@ class VerifyCommands(object):
"verifier extension, using command `rally verify "
"add-verifier-ext`."))
def _print_details_after_run(self, results):
failures = results.filter_tests("fail").values()
if failures:
h_text = "Failed %d %s - output below:" % (
len(failures), "tests" if len(failures) > 1 else "test")
self._print_failures(h_text, failures, "=")
else:
print(_("\nCongratulations! Verification doesn't have failed "
"tests! :)"))
@cliutils.help_group("verifier-ext")
@cliutils.args("--id", dest="verifier_id", type=str,
help="Verifier name or UUID. " + LIST_VERIFIERS_HINT)
@ -477,14 +487,7 @@ class VerifyCommands(object):
return 1
if detailed:
failures = results.filter_tests("fail").values()
if failures:
h_text = "Failed %d %s - output below:" % (
len(failures), "tests" if len(failures) > 1 else "test")
self._print_failures(h_text, failures, "=")
else:
print(_("\nCongratulations! Verification doesn't have failed "
"tests! :)"))
self._print_details_after_run(results)
self._print_totals(results.totals)
@ -512,16 +515,30 @@ class VerifyCommands(object):
help="Deployment name or UUID. " + LIST_DEPLOYMENTS_HINT)
@cliutils.args("--failed", dest="failed", required=False,
help="Rerun only failed tests.", action="store_true")
@cliutils.args("--detailed", dest="detailed", action="store_true",
required=False,
help="Show verification details such as errors of failed "
"tests.")
@cliutils.args("--no-use", dest="do_use", action="store_false",
help="Not to set the finished verification as the default "
"verification for future operations.")
@envutils.with_default_verification_uuid
@envutils.with_default_deployment(cli_arg_name="deployment-id")
@plugins.ensure_plugins_are_loaded
def rerun(self, api, verification_uuid=None, deployment=None,
failed=False):
failed=False, detailed=False, do_use=True):
"""Rerun tests from a verification for a specific deployment."""
verification, results = api.verification.rerun(verification_uuid,
deployment, failed)
if detailed:
self._print_details_after_run(results)
self._print_totals(results.totals)
print(_("Verification UUID: %s.") % verification.uuid)
if do_use:
self.use(api, verification.uuid)
else:
print(_("Verification UUID: %s.") % verification.uuid)
@cliutils.help_group("verification")
@cliutils.args("--uuid", dest="verification_uuid", type=str,