openstack
/
rally
Code Issues Proposed changes

Fix assertion methods 

Fix typos of assertion methods and misuse of assertTrue.

Change-Id: Ifb7f7af5823bd14e45b0a32047e2093e49a89dbb
This commit is contained in:
Takashi NATSUME 2019-06-20 13:23:53 +09:00
parent 1faee3eb42
commit 6df07c6c7f
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/unit/cli/commands/test_verify.py
View File

@ -178,7 +178,7 @@ class VerifyCommandsTestCase(test.TestCase):
"formatters"]
self.verify.list_verifiers(self.fake_api)
# astarove: should be replaced on mock_print_list.assert_called_once()
self.assertTrue(1, len(mock_print_list.call_args()))
self.assertEqual(1, mock_print_list.call_count)
self.assertEqual(([self.verifier_data], additional_fields),
mock_print_list.call_args[0])
self.assertEqual(additional_keys.sort(),
@ -669,7 +669,7 @@ class VerifyCommandsTestCase(test.TestCase):
additional_keys = ["normalize_field_names", "sortby_index",
"formatters"]
# astarove: Should be replaced on mock_print_list.assert_called_once())
self.assertTrue(1, len(mock_print_list.call_args()))
self.assertEqual(1, mock_print_list.call_count)
self.assertEqual(([self.verification_data], additional_fields),
mock_print_list.call_args[0])
self.assertEqual(additional_keys.sort(),

4
tests/unit/env/test_env_mgr.py vendored
View File

@ -436,9 +436,9 @@ class EnvManagerTestCase(test.TestCase):
def test_rename(self, mock_env_rename):
env = env_mgr.EnvManager({"uuid": "11", "name": "n"})
self.assertTrue(env.rename, env.rename("n"))
self.assertTrue(env.rename("n"))
self.assertEqual(0, mock_env_rename.call_count)
self.assertTrue(env.rename, env.rename("n2"))
self.assertTrue(env.rename("n2"))
mock_env_rename.assert_called_once_with("11", "n", "n2")
@mock.patch("rally.common.db.env_update")

6
tests/unit/test_api.py
View File

@ -1380,12 +1380,12 @@ class VerifierAPITestCase(test.TestCase):
verifier_obj.update_properties.assert_called_once_with(
status=verifier_obj.status, system_wide=True)
verifier_obj.update_status.reset_mock()
# check switching from system-wide to system-wide
verifier_obj.system_wide = True
expected_calls = len(verifier_obj.update_status.call_args())
self.verifier_inst.update(verifier_id=uuid, system_wide=True)
self.assertTrue(expected_calls,
len(verifier_obj.update_status.call_args()))
verifier_obj.update_status.assert_called_once_with(
consts.VerifierStatus.UPDATING)
self.assertFalse(verifier_obj.manager.install_venv.called)
@mock.patch("rally.api._Verifier._get")