Address G002 in flake8-logging-format 0.7.4

The current release of flake8-logging-format enforces G002 "Logging
statement uses '%'", so don't do that.

Also disable G200 ("Logging statement uses exception in arguments")
to be consistent with cinder.

Also, restore the pep8 job to voting status.

Change-Id: Ia4d40a85ac150b13575e98eb16e2607c5228b2f6
This commit is contained in:
Brian Rosmaita 2022-08-10 08:56:10 -04:00
parent fe63f0cc89
commit 8fe7c8a5d3
3 changed files with 6 additions and 8 deletions

View File

@ -10,9 +10,7 @@
check: check:
jobs: jobs:
- openstack-tox-pep8: - openstack-tox-pep8
# TODO: make voting when pep8 job is fixed
voting: false
- rbd-iscsi-client-py36 - rbd-iscsi-client-py36
- openstack-tox-py38 - openstack-tox-py38
- openstack-tox-py39 - openstack-tox-py39
@ -21,9 +19,7 @@
gate: gate:
jobs: jobs:
- openstack-tox-pep8: - openstack-tox-pep8
# TODO: make voting when pep8 job is fixed
voting: false
- rbd-iscsi-client-py36 - rbd-iscsi-client-py36
- openstack-tox-py38 - openstack-tox-py38
- openstack-tox-py39 - openstack-tox-py39

View File

@ -97,7 +97,7 @@ class RBDISCSIClient(object):
{'key': key, {'key': key,
'value': kwargs['data'][key]}) 'value': kwargs['data'][key]})
self._logger.debug("\nREQ: %s\n" % "".join(string_parts)) self._logger.debug("\nREQ: %s\n", "".join(string_parts))
def _http_log_resp(self, resp, body): def _http_log_resp(self, resp, body):
if not self.http_log_debug: if not self.http_log_debug:

View File

@ -117,9 +117,11 @@ commands = sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasen
# reason: no agreement on this being universally # reason: no agreement on this being universally
# preferable for our code. Disabled to keep checking # preferable for our code. Disabled to keep checking
# tools from getting in our way with regards to this. # tools from getting in our way with regards to this.
# G200 Logging statements should not include the exception
# reason: Many existing cases of this that may be legitimate
# #
show-source = True show-source = True
ignore = E251,W503,W504 ignore = E251,W503,W504,G200
enable-extensions=H106,H203,H204,H205 enable-extensions=H106,H203,H204,H205
builtins = _ builtins = _
exclude=.venv,.git,.tox,dist,*lib/python*,*egg,build exclude=.venv,.git,.tox,dist,*lib/python*,*egg,build