treat extra repos as errors

Require all repositories in a release to be listed in the
repository-settings section of the deliverable file.

Change-Id: I80c3763d62dd776af0912f92d20353d94d0e6d91
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

openstack_releases/cmds/validate.py

@@ -793,9 +793,7 @@ def validate_new_releases(deliverable_info, deliverable_name,
     repository_settings = deliverable_info.get('repository-settings', {})
     for repo in actual_repos:
         if repo not in repository_settings:
-            # TODO(dhellmann): Turn this into a warning after the T
-            # series is open.
-            mk_warning(
+            mk_error(
                 'release %s includes repository %s '
                 'that is not in the repository-settings section' %
                 (final_release['version'], repo)

openstack_releases/tests/test_validate.py

@@ -1340,8 +1340,8 @@ class TestValidateNewReleases(base.BaseTestCase):
             errors.append,
         )
         print(warnings, errors)
-        self.assertEqual(1, len(warnings))
-        self.assertEqual(0, len(errors))
+        self.assertEqual(0, len(warnings))
+        self.assertEqual(1, len(errors))
 
     def test_missing_repo_info(self):
         # The tag is missing a repository that is in