openstack/releases
Code Issues Proposed changes

convert warning for missing repo to error

Browse Source 
If a release does not include all of the repositories in the
deliverable report an error instead of a warning.

Change-Id: I7980b204995647fc77657123fa8d7bb565b55247
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann 2018-09-19 09:24:54 -04:00
parent 14d744ece1
commit 3013ead10c
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstack_releases/cmds/validate.py
View File

@ -1340,7 +1340,7 @@ def validate_new_releases(deliv, context):
) )
for missing in deliv.known_repo_names: for missing in deliv.known_repo_names:
if missing not in actual_repos: if missing not in actual_repos:
context.warning( context.error(
'release %s is missing %s, ' 'release %s is missing %s, '
'which appears in the repository-settings list' % 'which appears in the repository-settings list' %
(final_release.version, missing) (final_release.version, missing)

4
openstack_releases/tests/test_validate.py
View File

@ -1840,8 +1840,8 @@ class TestValidateNewReleases(base.BaseTestCase):
) )
validate.validate_new_releases(deliv, self.ctx) validate.validate_new_releases(deliv, self.ctx)
self.ctx.show_summary() self.ctx.show_summary()
self.assertEqual(1, len(self.ctx.warnings)) self.assertEqual(0, len(self.ctx.warnings))
self.assertEqual(0, len(self.ctx.errors)) self.assertEqual(1, len(self.ctx.errors))
class TestValidateBranchPrefixes(base.BaseTestCase): class TestValidateBranchPrefixes(base.BaseTestCase):