openstack/releases
Code Issues Proposed changes

use mocks for release note link checking

Browse Source 
Ensure the tests do not need internet access.

Change-Id: I4f3ea775314225bf7c300e921a04d5b9194eb680
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann
2018-03-10 18:11:51 -05:00
parent b8df43f4de
commit 502fd6dfcd
1 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
openstack_releases/tests/test_validate.py
View File

@@ -322,7 +322,9 @@ class TestValidateReleaseNotes(base.BaseTestCase):
self.assertEqual(0, len(self.ctx.warnings))
self.assertEqual(0, len(self.ctx.errors))
def test_invalid_link(self):
@mock.patch('requests.get')
def test_invalid_link(self, get):
get.return_value = mock.Mock(status_code=404)
validate.validate_release_notes(
deliverable.Deliverable(
team='team',
@@ -337,7 +339,9 @@ class TestValidateReleaseNotes(base.BaseTestCase):
self.assertEqual(0, len(self.ctx.warnings))
self.assertEqual(1, len(self.ctx.errors))
def test_valid_link(self):
@mock.patch('requests.get')
def test_valid_link(self, get):
get.return_value = mock.Mock(status_code=200)
validate.validate_release_notes(
deliverable.Deliverable(
team='team',
@@ -351,7 +355,9 @@ class TestValidateReleaseNotes(base.BaseTestCase):
self.assertEqual(0, len(self.ctx.warnings))
self.assertEqual(0, len(self.ctx.errors))
def test_invalid_link_multi(self):
@mock.patch('requests.get')
def test_invalid_link_multi(self, get):
get.return_value = mock.Mock(status_code=404)
validate.validate_release_notes(
deliverable.Deliverable(
team='team',
@@ -372,7 +378,9 @@ class TestValidateReleaseNotes(base.BaseTestCase):
self.assertEqual(0, len(self.ctx.warnings))
self.assertEqual(1, len(self.ctx.errors))
def test_unknown_repo(self):
@mock.patch('requests.get')
def test_unknown_repo(self, get):
get.return_value = mock.Mock(status_code=200)
validate.validate_release_notes(
deliverable.Deliverable(
team='team',
@@ -393,7 +401,9 @@ class TestValidateReleaseNotes(base.BaseTestCase):
self.assertEqual(0, len(self.ctx.warnings))
self.assertEqual(1, len(self.ctx.errors))
def test_valid_link_multi(self):
@mock.patch('requests.get')
def test_valid_link_multi(self, get):
get.return_value = mock.Mock(status_code=200)
validate.validate_release_notes(
deliverable.Deliverable(
team='team',