openstack/releases
Code Issues Proposed changes

Skip branch checking on EOL deliverables

Browse Source 
If we make modifications to a deliverable file for whatever reason and
that series is EOL, the validation code would still check that branches
existed and therefore fail. The stable/$series branch most likely is
deleted after going EOL, so the validation code would think there was a
need for a new branch to be created, then fail if the last release done
was not the same point as the branch.

This updates the validation logic to check up front if the deliverable
is EOL and skip these checks.

Change-Id: Ib5be3c0ba7283021301d278fcb362432f9a7d5cb
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
This commit is contained in:
Sean McGinnis 2019-07-08 14:28:58 -05:00
parent b6ca269386
commit aa3ab893c2
No known key found for this signature in database
GPG Key ID: CE7EE4BFAF8D70C8
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openstack_releases/cmds/validate.py
View File

@ -1437,6 +1437,10 @@ def validate_stable_branches(deliv, context):
branch_mode = deliv.stable_branch_type branch_mode = deliv.stable_branch_type
if deliv.releases and deliv.releases[-1].is_eol:
print('rule does not apply to end-of-life repos, skipping')
return
known_series = sorted(list( known_series = sorted(list(
d for d in os.listdir('deliverables') d for d in os.listdir('deliverables')
if not d.startswith('_') if not d.startswith('_')