Merge "run bashate as part of the linters gate"

tox.ini

@@ -39,19 +39,24 @@ commands = validate-constraints {toxinidir}/global-requirements.txt {toxinidir}/
 [testenv:validate-projects]
 commands = validate-projects {toxinidir}/projects.txt
 
+# TODO remove once zuul reconfigured to run linters on gate
 [testenv:pep8]
-deps = hacking>=1.0.0
+deps = {[testenv:linters]deps}
-basepython = python3
+whitelist_externals = {[testenv:linters]whitelist_externals}
-commands = flake8
+commands = {[testenv:linters]commands}
 
-[testenv:bashate]
+[testenv:linters]
+deps =
+    hacking>=1.0.0
+    bashate>=0.5.1
 whitelist_externals = bash
-# E006: Line too long:
+basepython = python3
-# E010: The "do" should be on same line as for
+commands =
-commands = bash -c "find {toxinidir}/tools      \
+    flake8
-                        -type f                 \
+    bash -c "find {toxinidir}/tools      \
-                        -name \*.sh             \
+                 -type f                 \
-                        -print0 | xargs -0 bashate -v -iE006,E010"
+                 -name \*.sh             \
+                 -print0 | xargs -0 bashate -v -iE006,E010"
 
 [testenv:bindep]
 # Do not install any requirements. We want this to be fast and work even if