openstack/requirements
Code Issues Proposed changes

Replace assertItemsEqual with assertCountEqual

Browse Source 
assertItemsEqual was removed from Python's unittest.TestCase in
Python 3.3 [1][2]. We have been able to use them since then, because
testtools required unittest2, which still included it. With testtools
removing Python 2.7 support [3][4], we will lose support for
assertItemsEqual, so we should switch to use assertCountEqual.

[1] - https://bugs.python.org/issue17866
[2] - https://hg.python.org/cpython/rev/d9921cb6e3cd
[3] - https://github.com/testing-cabal/testtools/issues/286
[4] - https://github.com/testing-cabal/testtools/pull/277

Signed-off-by: Takashi Natsume <takanattie@gmail.com>
Change-Id: I485b6f1c44185eaf327aadb044d6d2b1dce40eb2
This commit is contained in:
Takashi Natsume 2021-05-23 17:09:37 +09:00
parent 70c16cff5c
commit 7a55d689e0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstack_requirements/tests/test_requirement.py
View File

@ -189,7 +189,7 @@ class TestToReqs(testtools.TestCase):
frozenset(('fixtures',)))
self.assertEqual(reqs['oslo.db'][0][0].extras,
frozenset(('fixtures', 'mysql')))
self.assertItemsEqual(reqs,
self.assertCountEqual(reqs,
['oslo.config', 'oslo.concurrency', 'oslo.db'])