openstack/reviewday
Code Issues Proposed changes

Make the review list sortable by review type

Browse Source 
Especially for bug review days it makes sense to sort the current
review list by review type (high prio bugfix, medium prio bugfix, ...)
This patch set introduces a new column "type" and allows a sorting for
it.

Change-Id: I3d37cccb8d6f75f6eebc2cf8ab9136ac50d4cf89
This commit is contained in:
Markus Zoeller 2015-08-07 16:41:36 +02:00
parent 02b43d1ce3
commit 0517c7a499
2 changed files with 33 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
reviewday/mergeprop.py
View File

@ -1,5 +1,22 @@
class MergeProp(object):
cause_score = {
'Regression hotfix': 350,
'Critical bugfix': 340,
'Essential feature': 330,
'High feature': 230,
'Medium feature': 180,
'High bugfix': 130,
'Low feature': 100,
'Medium bugfix': 70,
'Low bugfix': 50,
'Undefined feature': 40,
'Wishlist bugfix': 35,
'Undecided bugfix': 30,
'Untargeted feature': 10,
'No link': 0,
}
def _calc_score(self, lp, cur_timestamp):
cause = 'No link'
try:
@ -19,28 +36,11 @@ class MergeProp(object):
print 'WARNING: unable to find cause for %s' % self.topic
cause = 'No link'
cause_score = {
'Regression hotfix': 350,
'Critical bugfix': 340,
'Essential feature': 330,
'High feature': 230,
'Medium feature': 180,
'High bugfix': 130,
'Low feature': 100,
'Medium bugfix': 70,
'Low bugfix': 50,
'Undefined feature': 40,
'Wishlist bugfix': 35,
'Undecided bugfix': 30,
'Untargeted feature': 10,
'No link': 0,
}
if cause not in cause_score:
if cause not in MergeProp.cause_score:
print 'WARNING: unable to find score for ' \
'(%s, %s)' % (self.topic, cause)
return ("No link", "Unknown cause: " + cause, 0)
score = cause_score[cause]
score = MergeProp.cause_score[cause]
reason = [cause + " (+%d)" % (score)]
# Add a score based on the time the patch has been waiting for approval
days_old = int((cur_timestamp - self.revisionCreatedOn) / 86400)
@ -88,3 +88,4 @@ class MergeProp(object):
self.score = score
self.reason = reason
self.cause = cause
self.rank = MergeProp.cause_score[cause]

15
reviewday/report.html
View File

@ -60,7 +60,13 @@
<tr>
<th>
<a class="sortheader" href="#" onclick="ts_resortTable(this); return false;">
Type / Subject
Type
<img class="sortarrow" height="6" src="arrowBlank" width="9"/>
</a>
</th>
<th>
<a class="sortheader" href="#" onclick="ts_resortTable(this); return false;">
Subject
<img class="sortarrow" height="6" src="arrowBlank" width="9"/>
</a>
</th>
@ -95,11 +101,16 @@
<tbody>
#for $mp in $mergeprops
<tr>
<td>
<img src="${mp.cause.replace(' ', '').upper()}.png" title="$mp.cause"/>
<span class="sortkey">
$mp.rank
</span>
</td>
<td>
<span class="sortkey">
12
</span>
<img src="${mp.cause.replace(' ', '').upper()}.png" title="$mp.cause"/>
#filter WebSafe
<a href="$mp.url" title="${mp.subject, also='"'}">
${mp.subject[:60], also='"'}