openstack/reviewstats
Code Issues Proposed changes

openapproved: ignore patches with a negative VRIF

Browse Source 
In addition to ignoring patches with a negative review, ignore patches
that fail jenkins tests. As a negative VRIF implies the patch isn't
ready to be approved again.

Clarify docstring, to point trying to identify trivial rebases only.

Change-Id: I812ad787cf6aa06d1ea05b2a0b70574b907b8777
Reviewed-on: https://review.openstack.org/36416
Approved: Russell Bryant <rbryant@redhat.com>
Reviewed-by: Russell Bryant <rbryant@redhat.com>
Tested-by: Jenkins
This commit is contained in:
Joe Gordon 2013-07-10 10:14:54 +01:00 committed by Jenkins
parent 0caa9bf4f1
commit 9022c2d416
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
openapproved.py
View File

@ -16,10 +16,10 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
"""Identify approved and open patches. """Identify approved and open patches, that are probably just trivial rebases.
Prints out list of approved patches that failed to merge and are currently Prints out list of approved patches that failed to merge and are currently
still open. still open. Only show patches that are likely to be trivial rebases.
""" """
import optparse import optparse
@ -75,7 +75,7 @@ def main(argv=None):
def has_negative_feedback(patch_set): def has_negative_feedback(patch_set):
approvals = patch_set.get('approvals', []) approvals = patch_set.get('approvals', [])
for review in approvals: for review in approvals:
if review['type'] == 'CRVW' and review['value'] in ('-1', '-2'): if review['type'] in ('CRVW','VRIF') and review['value'] in ('-1', '-2'):
return True return True
return False return False