openstack/reviewstats
Code Issues Proposed changes

Show longest waiting first in the list

Browse Source 
Change-Id: I88bb5b815dd795c34b39e0f4c01f04a38c63351e
Reviewed-on: https://review.openstack.org/36069
Reviewed-by: Russell Bryant <rbryant@redhat.com>
Approved: Russell Bryant <rbryant@redhat.com>
Tested-by: Jenkins
This commit is contained in:
Russell Bryant 2013-07-08 08:32:44 -04:00 committed by Jenkins
parent 094c1d2389
commit c1c36e1fb0
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
openreviews.py
View File

@ -78,9 +78,12 @@ def number_waiting_more_than(changes, seconds, key='age'):
def gen_stats(projects, waiting_on_reviewer, waiting_on_submitter, options): def gen_stats(projects, waiting_on_reviewer, waiting_on_submitter, options):
age_sorted = sorted(waiting_on_reviewer, key=lambda change: change['age']) age_sorted = sorted(waiting_on_reviewer,
age2_sorted = sorted(waiting_on_reviewer, key=lambda change: change['age2']) key=lambda change: change['age'], reverse=True)
age3_sorted = sorted(waiting_on_reviewer, key=lambda change: change['age3']) age2_sorted = sorted(waiting_on_reviewer,
key=lambda change: change['age2'], reverse=True)
age3_sorted = sorted(waiting_on_reviewer,
key=lambda change: change['age3'], reverse=True)
result = [] result = []
result.append(('Projects', '%s' % [project['name'] result.append(('Projects', '%s' % [project['name']
@ -117,21 +120,21 @@ def gen_stats(projects, waiting_on_reviewer, waiting_on_submitter, options):
last_without_nack_stats)) last_without_nack_stats))
changes = [] changes = []
for change in age_sorted[-options.longest_waiting:]: for change in age_sorted[:options.longest_waiting]:
changes.append('%s %s (%s)' % (sec_to_period_string(change['age']), changes.append('%s %s (%s)' % (sec_to_period_string(change['age']),
change['url'], change['subject'])) change['url'], change['subject']))
stats.append(('Longest waiting reviews (based on latest revision)', stats.append(('Longest waiting reviews (based on latest revision)',
changes)) changes))
changes = [] changes = []
for change in age2_sorted[-options.longest_waiting:]: for change in age2_sorted[:options.longest_waiting]:
changes.append('%s %s (%s)' % (sec_to_period_string(change['age2']), changes.append('%s %s (%s)' % (sec_to_period_string(change['age2']),
change['url'], change['subject'])) change['url'], change['subject']))
stats.append(('Longest waiting reviews (based on first revision)', stats.append(('Longest waiting reviews (based on first revision)',
changes)) changes))
changes = [] changes = []
for change in age3_sorted[-options.longest_waiting:]: for change in age3_sorted[:options.longest_waiting]:
changes.append('%s %s (%s)' % (sec_to_period_string(change['age3']), changes.append('%s %s (%s)' % (sec_to_period_string(change['age3']),
change['url'], change['subject'])) change['url'], change['subject']))
stats.append(('Longest waiting reviews (based on oldest rev without nack, ignoring jenkins)', stats.append(('Longest waiting reviews (based on oldest rev without nack, ignoring jenkins)',