Make almost all the element scripts as e/u/pipefail

Following the latest dib-lint reporting, make sure almost all the scripts are enabling -e, -u, and pipefail. This eases the discovery of failing commands, and the usage of unset variables. There are few exceptions with flags not set: * elements/hadoop-hdp/install.d/40-install-hdp, set -e when installing HDP 2.0, it tries to install tez, which does not seem to exist in Hortonworks' repositories * elements/ssh/install.d/33-ssh, set -e the version of augtool (part of augeas 0.10) in older Ubuntu versions (like Precise, needed by the cloudera plugin) exits with wrong return values in autosave mode * elements/storm/install.d/60-storm, set -e It tries to change the permission of /etc/supervisord.conf, which does not seem to exist Change-Id: Ic1314639dfc6a66c48ca87b6820707a2b0cb1dbd Partial-Bug: #1435306
2015-04-07 10:36:42 +02:00 · 2015-04-07 10:36:42 +02:00 · 2fb2422da8
parent 157dd805e6
commit 2fb2422da8
62 changed files with 112 additions and 8 deletions
--- a/elements/apt-mirror/finalise.d/99-setup
+++ b/elements/apt-mirror/finalise.d/99-setup
@ -3,5 +3,7 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 rm /etc/apt/apt.conf.d/01proxy
--- a/elements/apt-mirror/pre-install.d/00-apt
+++ b/elements/apt-mirror/pre-install.d/00-apt
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 mkdir -p /etc/apt/apt.conf.d/
 touch /etc/apt/apt.conf.d/01proxy
--- a/elements/apt-mirror/root.d/0-check
+++ b/elements/apt-mirror/root.d/0-check
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 if [ -z "$UBUNTU_MIRROR" ]; then
    echo "You should specify parameter 'UBUNTU_MIRROR'"
--- a/elements/centos-mirror/finalise.d/99-setup
+++ b/elements/centos-mirror/finalise.d/99-setup
@ -3,5 +3,7 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 mv /opt/repos/* /etc/yum.repos.d/
--- a/elements/centos-mirror/pre-install.d/00-yum
+++ b/elements/centos-mirror/pre-install.d/00-yum
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 mkdir -p /opt/repos
 mv /etc/yum.repos.d/* /opt/repos/
--- a/elements/centos-mirror/root.d/0-check
+++ b/elements/centos-mirror/root.d/0-check
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 if [ -z "$CENTOS_MIRROR" ]; then
    echo "You should specify parameter 'CENTOS_MIRROR'"
--- a/elements/disable-firewall/post-install.d/30-disable-firewalld
+++ b/elements/disable-firewall/post-install.d/30-disable-firewalld
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 install-packages which

--- a/elements/disable-firewall/post-install.d/31-disable-ip6tables
+++ b/elements/disable-firewall/post-install.d/31-disable-ip6tables
@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
-set -e
+set -eu
+set -o pipefail

 if [ "$DISTRO_NAME" = "fedora" ]; then
    install-packages iptables-services
--- a/elements/disable-firewall/post-install.d/32-disable-iptables
+++ b/elements/disable-firewall/post-install.d/32-disable-iptables
@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
-set -e
+set -eu
+set -o pipefail

 if [ "$DISTRO_NAME" = "fedora" ]; then
    install-packages iptables-services
--- a/elements/fedora-mirror/finalise.d/99-setup
+++ b/elements/fedora-mirror/finalise.d/99-setup
@ -3,5 +3,7 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 mv /opt/repos/* /etc/yum.repos.d/
--- a/elements/fedora-mirror/pre-install.d/00-yum
+++ b/elements/fedora-mirror/pre-install.d/00-yum
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 mkdir -p /opt/repos
 mv /etc/yum.repos.d/* /opt/repos
--- a/elements/fedora-mirror/root.d/0-check
+++ b/elements/fedora-mirror/root.d/0-check
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 if [ -z "$FEDORA_MIRROR" ]; then
    echo "You should specify parameter 'FEDORA_MIRROR'"
--- a/elements/hadoop-cdh/post-install.d/40-setup-hadoop
+++ b/elements/hadoop-cdh/post-install.d/40-setup-hadoop
@ -7,6 +7,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 if [ "$DISTRO_NAME" != "ubuntu" ]; then
    echo "Distro $DISTRO_NAME not supported by CDH. Exiting."
--- a/elements/hadoop-cdh/post-install.d/50-cdh-fixes
+++ b/elements/hadoop-cdh/post-install.d/50-cdh-fixes
@ -6,6 +6,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 case "$DISTRO_NAME" in
    ubuntu )
--- a/elements/hadoop-cdh/root.d/0-check-hadoop-cdh
+++ b/elements/hadoop-cdh/root.d/0-check-hadoop-cdh
@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
-set -e
+set -eu
+set -o pipefail

 if [ -z "$JAVA_DOWNLOAD_URL" ]; then
    if [ -z "$JAVA_FILE" ]; then
--- a/elements/hadoop-cloudera/install.d/50-install-cloudera
+++ b/elements/hadoop-cloudera/install.d/50-install-cloudera
@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
 set -eu
+set -o pipefail

 if [ "$DISTRO_NAME" = "ubuntu" ]; then
    export DEBIAN_FRONTEND=noninteractive
--- a/elements/hadoop-cloudera/install.d/60-install-extjs
+++ b/elements/hadoop-cloudera/install.d/60-install-extjs
@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
-set -e
+set -eu
+set -o pipefail

 install-packages wget unzip

--- a/elements/hadoop-cloudera/post-install.d/70-turn-services-off
+++ b/elements/hadoop-cloudera/post-install.d/70-turn-services-off
@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
 set -eu
+set -o pipefail

 for i in cloudera-scm-agent \
 cloudera-scm-server \
--- a/elements/hadoop-cloudera/pre-install.d/10-add-mirror
+++ b/elements/hadoop-cloudera/pre-install.d/10-add-mirror
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 function add_repo_5_0_0 {
    case $DISTRO_NAME in
--- a/elements/hadoop-hdp/install.d/20-nozeroconf
+++ b/elements/hadoop-hdp/install.d/20-nozeroconf
@ -25,5 +25,7 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 echo "NOZEROCONF=yes" >> /etc/sysconfig/network
--- a/elements/hadoop-hdp/install.d/30-init-hdp-install
+++ b/elements/hadoop-hdp/install.d/30-init-hdp-install
@ -23,6 +23,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 install-packages wget
 install-packages ntp
--- a/elements/hadoop-hdp/install.d/40-install-hdp
+++ b/elements/hadoop-hdp/install.d/40-install-hdp
@ -27,6 +27,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -u
+set -o pipefail

 function install_ganglia {
    # Install ganglia
--- a/elements/hadoop-hdp/post-install.d/10-disable-repos
+++ b/elements/hadoop-hdp/post-install.d/10-disable-repos
@ -29,5 +29,7 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 find /etc/yum.repos.d -name "*.repo" -type f | xargs sed "s/enabled=1/enabled=0/" -i
--- a/elements/hadoop-hdp/post-install.d/20-cleanup
+++ b/elements/hadoop-hdp/post-install.d/20-cleanup
@ -23,6 +23,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 # ===== CLEANUP MISC  =====
 rm -rf /var/cache/*
--- a/elements/hadoop-hdp/post-install.d/40-turn-off-gmetad
+++ b/elements/hadoop-hdp/post-install.d/40-turn-off-gmetad
@ -24,6 +24,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 # Turn off gmetad
 chkconfig gmetad off
--- a/elements/hadoop-hdp/post-install.d/50-turn-on-ntpd
+++ b/elements/hadoop-hdp/post-install.d/50-turn-on-ntpd
@ -24,6 +24,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 # Turn on ntp service
 chkconfig ntpd on
--- a/elements/hadoop-hdp/post-install.d/55-turn-off-ambari-services
+++ b/elements/hadoop-hdp/post-install.d/55-turn-off-ambari-services
@ -24,6 +24,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 # Turn off ambari-server service for the first boot of this image
 chkconfig ambari-server off
--- a/elements/hadoop-hdp/post-install.d/58-turn-off-hadoop-2-services
+++ b/elements/hadoop-hdp/post-install.d/58-turn-off-hadoop-2-services
@ -28,6 +28,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 # This is only necessary for an HDP 2.x install
 if [[ $DIB_HDP_VERSION == "2.0"  ]]; then
--- a/elements/hadoop-hdp/post-install.d/60-enable-local-hdp-repos
+++ b/elements/hadoop-hdp/post-install.d/60-enable-local-hdp-repos
@ -25,6 +25,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 # create a new local yum repository definition that
 # includes:
--- a/elements/hadoop-mapr/install.d/40-mapr-dependencies
+++ b/elements/hadoop-mapr/install.d/40-mapr-dependencies
@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
 set -eu
+set -o pipefail

 echo "START: installing MapR core dependencies"

--- a/elements/hadoop-mapr/install.d/41-scala
+++ b/elements/hadoop-mapr/install.d/41-scala
@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
 set -eu
+set -o pipefail

 echo "START: installing Scala"

--- a/elements/hadoop-mapr/install.d/42-versions
+++ b/elements/hadoop-mapr/install.d/42-versions
@ -4,5 +4,6 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
 set -eu
+set -o pipefail

 install -D -g root -o root -m 0644 $(dirname $0)/versions.py /tmp/versions.py
--- a/elements/hadoop-mapr/install.d/43-mapr-core-repository
+++ b/elements/hadoop-mapr/install.d/43-mapr-core-repository
@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
 set -eu
+set -o pipefail

 echo "START: installing MapR core repository"

--- a/elements/hadoop-mapr/install.d/44-mapr-eco-repository
+++ b/elements/hadoop-mapr/install.d/44-mapr-eco-repository
@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
 set -eu
+set -o pipefail

 echo "START: installing MapR ecosystem repository"

--- a/elements/hadoop-mapr/install.d/44-oozie-libs
+++ b/elements/hadoop-mapr/install.d/44-oozie-libs
@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
 set -eu
+set -o pipefail

 echo "START: downloading ExtJS library"

--- a/elements/hadoop-mapr/post-install.d/99-requiretty
+++ b/elements/hadoop-mapr/post-install.d/99-requiretty
@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
 set -eu
+set -o pipefail

 if [ "$DISTRO_NAME" = "centos" -o "$DISTRO_NAME" = "rhel" ]; then
    sed '/^Defaults    requiretty*/ s/^/#/' -i /etc/sudoers
--- a/elements/hadoop-mapr/post-install.d/99-update-repository
+++ b/elements/hadoop-mapr/post-install.d/99-update-repository
@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
 set -eu
+set -o pipefail

 if [ "$DISTRO_NAME" = "ubuntu" ]; then
    apt-get update
--- a/elements/hadoop-mapr/root.d/0-mapr-check-version
+++ b/elements/hadoop-mapr/root.d/0-mapr-check-version
@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
 set -eu
+set -o pipefail

 echo "MapR version ${DIB_MAPR_VERSION}"

--- a/elements/hadoop/post-install.d/40-setup-hadoop
+++ b/elements/hadoop/post-install.d/40-setup-hadoop
@ -10,6 +10,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 function download_hadoop_package {
    echo "Hadoop version $DIB_HADOOP_VERSION will be injected into image. Starting the download"
--- a/elements/hadoop/root.d/0-check-hadoop
+++ b/elements/hadoop/root.d/0-check-hadoop
@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
-set -e
+set -eu
+set -o pipefail

 if [ -z "${JAVA_DOWNLOAD_URL:-}" ]; then
    if [ -z "${JAVA_FILE:-}" ]; then
--- a/elements/hive/post-install.d/60-hive
+++ b/elements/hive/post-install.d/60-hive
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 install-packages wget tar

--- a/elements/hive/root.d/0-check-hive
+++ b/elements/hive/root.d/0-check-hive
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 if [ -z "${HIVE_DOWNLOAD_URL:-}" ]; then
    version_check=$(echo $HIVE_VERSION | sed -e '/[0-9]\.[0-9][0-9]\.[0-9]/d')
--- a/elements/java/cleanup.d/00-clean-java-vars
+++ b/elements/java/cleanup.d/00-clean-java-vars
@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
 set -eu
+set -o pipefail

 unset DIB_JAVA_DISTRO
 unset JAVA_RC
--- a/elements/mysql/install.d/10-mysql
+++ b/elements/mysql/install.d/10-mysql
@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
-set -e
+set -eu
+set -o pipefail

 if [ "$DISTRO_NAME" = "fedora" ]; then
    install-packages community-mysql community-mysql-libs community-mysql-server mysql-connector-java
--- a/elements/mysql/install.d/99-disable-mysql-on-boot
+++ b/elements/mysql/install.d/99-disable-mysql-on-boot
@ -7,6 +7,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 if [ "$DISTRO_NAME" = "ubuntu" ]; then
    if [ -e "/etc/init/mysql.conf" ]; then
--- a/elements/oozie/install.d/50-setup-oozie
+++ b/elements/oozie/install.d/50-setup-oozie
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 echo "Oozie setup"

--- a/elements/oozie/post-install.d/90-oozie-war
+++ b/elements/oozie/post-install.d/90-oozie-war
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 install-packages wget

--- a/elements/oozie/root.d/0-check-oozie
+++ b/elements/oozie/root.d/0-check-oozie
@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
-set -e
+set -eu
+set -o pipefail

 if [[ "$DIB_HADOOP_VERSION" < "2.0.0" ]]; then
    if [ -z "${OOZIE_HADOOP_V1_DOWNLOAD_URL:-}" -a -z "${OOZIE_HADOOP_V1_FILE:-}" ]; then
--- a/elements/oracle-java/install.d/33-java
+++ b/elements/oracle-java/install.d/33-java
@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
-set -e
+set -eu
+set -o pipefail

 echo "Begin: installation of Java"

--- a/elements/redhat-lsb/pre-install.d/02-lsb
+++ b/elements/redhat-lsb/pre-install.d/02-lsb
@ -3,5 +3,7 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 install-packages redhat-lsb
--- a/elements/root-passwd/post-install.d/99-setup
+++ b/elements/root-passwd/post-install.d/99-setup
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 if [ -z "$DIB_PASSWORD" ]; then
    echo "Error during setup password for root"
--- a/elements/sahara-version/install.d/01-sahara-version
+++ b/elements/sahara-version/install.d/01-sahara-version
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 if [ -z "$SAHARA_ELEMENTS_COMMIT_ID" -o -z "$DIB_UTILS_COMMIT_ID" -o -z "$DIB_COMMIT_ID" ]; then
    echo "SAHARA_ELEMENTS_COMMIT_ID, DIB_UTILS_COMMIT_ID and DIB_COMMIT_ID must be specified, exiting"
--- a/elements/spark/install.d/60-spark
+++ b/elements/spark/install.d/60-spark
@ -5,6 +5,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 install-packages wget tar

--- a/elements/spark/post-install.d/20-spark
+++ b/elements/spark/post-install.d/20-spark
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 # We have to chown the Spark directories to make it usable for the default user
 # Unfortunately the Ubuntu user does not exists when DIB is creating the image
--- a/elements/spark/root.d/0-check-spark
+++ b/elements/spark/root.d/0-check-spark
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 if [ -z "${SPARK_DOWNLOAD_URL:-}" -a -z "${DIB_HADOOP_VERSION:-}" ]; then
    echo -e "Neither DIB_HADOOP_VERSION nor SPARK_DOWNLOAD_URL are set. Impossible to install Spark.\nAborting"
--- a/elements/ssh/install.d/33-ssh
+++ b/elements/ssh/install.d/33-ssh
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -u
+set -o pipefail
 echo "Begin: install and configure SSH"

 # /etc/ssh/sshd_config is provided by openssh-server
--- a/elements/storm/install.d/60-storm
+++ b/elements/storm/install.d/60-storm
@ -5,6 +5,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -u
+set -o pipefail

 install-packages wget unzip build-essential uuid-dev git libtool autoconf pkg-config tar

--- a/elements/storm/root.d/0-check-storm
+++ b/elements/storm/root.d/0-check-storm
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 if [ -z "${STORM_DOWNLOAD_URL:-}" -a -z "${DIB_STORM_VERSION:-}"]; then
    echo -e "Neither DIB_STORM_VERSION nor STORM_DOWNLOAD_URL are set. Impossible to install Storm.\nAborting"
--- a/elements/swift_hadoop/post-install.d/81-add-jar
+++ b/elements/swift_hadoop/post-install.d/81-add-jar
@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 install-packages wget

--- a/elements/updater/install.d/00-updater
+++ b/elements/updater/install.d/00-updater
@ -3,5 +3,7 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 install-packages -u
--- a/elements/zookeeper/install.d/40-zookeeper
+++ b/elements/zookeeper/install.d/40-zookeeper
@ -5,6 +5,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 install-packages wget

--- a/elements/zookeeper/post-install.d/50-zookeeper
+++ b/elements/zookeeper/post-install.d/50-zookeeper
@ -7,6 +7,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
    set -x
 fi
+set -eu
+set -o pipefail

 sed -i -e 's,^exit 0$,[ -f /opt/zookeeper/firstboot.sh ] \&\& sh /opt/zookeeper/firstboot.sh; exit 0,' /etc/rc.local