openstack/searchlight
Code Issues Proposed changes
df6b22212a
searchlight/HACKING.rst
lihaijing f00d30d10c Remove log translations 
Log messages are no longer being translated. This removes all use of
the _LE, _LI, and _LW translation markers to simplify logging and to
avoid confusion with new contributions.

See:
http://lists.openstack.org/pipermail/openstack-i18n/2016-November/002574.html
http://lists.openstack.org/pipermail/openstack-dev/2017-March/113365.html
https://review.openstack.org/#/c/446762/

Change-Id: Icb6f8ff97e82b13dcd894d006dc06bb91e77354f
2017-03-27 15:45:17 +08:00

844 B
Raw Blame History

Searchlight Style Commandments

Searchlight Specific Commandments

  • [SL316] Change assertTrue(isinstance(A, B)) by optimal assert like assertIsInstance(A, B)
  • [SL317] Change assertEqual(type(A), B) by optimal assert like assertIsInstance(A, B)
  • [SL318] Change assertEqual(A, None) or assertEqual(None, A) by optimal assert like assertIsNone(A)
  • [SL319] Validate that debug level logs are not translated
  • [SL320] For python 3 compatibility, use six.text_type() instead of unicode()
  • [SL321] Validate that LOG messages, except debug ones, have translations
  • [SL327] Prevent use of deprecated contextlib.nested
  • [SL343] Check for common double word typos