openstack/senlin
Code Issues Proposed changes

Fix webhook middleware test case

Browse Source 
The previous test case failed to emulate the incorrect format of
triggering url when '/' split is incorrect. This patch fixes it.

Change-Id: I2fdaa50b1dae8d7385db70a3cb1723083ccdfeae
This commit is contained in:
tengqm
2015-08-10 09:52:45 -04:00
parent 2bd45c328c
commit 9983d53132
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
senlin/tests/unit/middleware/test_webhook_middleware.py
View File

@@ -56,7 +56,7 @@ class TestWebhookMiddleware(base.SenlinTestCase):
res = self.middleware._extract_webhook_id(self._generate_url())
self.assertEqual(self.url_slices['03_webhook_id'], res)
def test_extract_webhook_id_webhookid_not_found(self):
def test_extract_webhook_id_webhooks_not_found(self):
# String 'webhooks' is not found in url
self.url_slices['02_webhook_str'] = '/foo/'
res = self.middleware._extract_webhook_id(self._generate_url())
@@ -69,8 +69,8 @@ class TestWebhookMiddleware(base.SenlinTestCase):
self.assertIsNone(res)
def test_extract_webhook_id_illegal_format(self):
# The structure /<webhook_id>?key=value is not matched
self.url_slices['02_webhook_str'] = '/webhook'
# The structure /<webhook_id>/trigger?key=value is not matched
self.url_slices['04_trigger_str'] = 'trigger?'
res = self.middleware._extract_webhook_id(self._generate_url())
self.assertIsNone(res)