Update patch set 4
Patch Set 4: (11 comments) Patch-set: 4 Label: Workflow=0
This commit is contained in:
Gerrit User 26340
Gerrit Code Review
parent
b263b60859
commit
50801ee3d4
|
|
@ -1,5 +1,28 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_e1009f37",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 51,
|
||||
"author": {
|
||||
"id": 26340
|
||||
},
|
||||
"writtenOn": "2018-07-21T06:04:22Z",
|
||||
"side": 1,
|
||||
"message": "Better refer by Change-Id",
|
||||
"range": {
|
||||
"startLine": 51,
|
||||
"startChar": 0,
|
||||
"endLine": 51,
|
||||
"endChar": 18
|
||||
},
|
||||
"revId": "772f18a2c297646b0d14f86eabf19847ba60e5d0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_259b0c64",
|
||||
|
|
@ -40,6 +63,29 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_615faf74",
|
||||
"filename": "sushy_tools/emulator/drivers/libvirtdriver.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 346,
|
||||
"author": {
|
||||
"id": 26340
|
||||
},
|
||||
"writtenOn": "2018-07-21T06:04:22Z",
|
||||
"side": 1,
|
||||
"message": "It seems that the code also updates XML tree if the `bios` branch is missing there regardless of the flag.",
|
||||
"range": {
|
||||
"startLine": 346,
|
||||
"startChar": 30,
|
||||
"endLine": 346,
|
||||
"endChar": 38
|
||||
},
|
||||
"revId": "772f18a2c297646b0d14f86eabf19847ba60e5d0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_745d34ea",
|
||||
|
|
@ -138,6 +184,75 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_e19f3f4e",
|
||||
"filename": "sushy_tools/emulator/drivers/libvirtdriver.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 368,
|
||||
"author": {
|
||||
"id": 26340
|
||||
},
|
||||
"writtenOn": "2018-07-21T06:04:22Z",
|
||||
"side": 1,
|
||||
"message": "nit: tuple is not required",
|
||||
"range": {
|
||||
"startLine": 368,
|
||||
"startChar": 66,
|
||||
"endLine": 368,
|
||||
"endChar": 68
|
||||
},
|
||||
"revId": "772f18a2c297646b0d14f86eabf19847ba60e5d0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_812bebe7",
|
||||
"filename": "sushy_tools/emulator/drivers/libvirtdriver.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 370,
|
||||
"author": {
|
||||
"id": 26340
|
||||
},
|
||||
"writtenOn": "2018-07-21T06:04:22Z",
|
||||
"side": 1,
|
||||
"message": "does it make sense to sort the elements to ensure stable XML?",
|
||||
"range": {
|
||||
"startLine": 370,
|
||||
"startChar": 46,
|
||||
"endLine": 370,
|
||||
"endChar": 51
|
||||
},
|
||||
"revId": "772f18a2c297646b0d14f86eabf19847ba60e5d0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_21f9b780",
|
||||
"filename": "sushy_tools/emulator/drivers/libvirtdriver.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 372,
|
||||
"author": {
|
||||
"id": 26340
|
||||
},
|
||||
"writtenOn": "2018-07-21T06:04:22Z",
|
||||
"side": 1,
|
||||
"message": "is it alright that namespace clarification here is done like `sushy:` while for `attributes` it\u0027s done like `{namespace}`?",
|
||||
"range": {
|
||||
"startLine": 372,
|
||||
"startChar": 31,
|
||||
"endLine": 372,
|
||||
"endChar": 46
|
||||
},
|
||||
"revId": "772f18a2c297646b0d14f86eabf19847ba60e5d0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_c5701844",
|
||||
|
|
@ -201,6 +316,29 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_21553752",
|
||||
"filename": "sushy_tools/emulator/drivers/libvirtdriver.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 393,
|
||||
"author": {
|
||||
"id": 26340
|
||||
},
|
||||
"writtenOn": "2018-07-21T06:04:22Z",
|
||||
"side": 1,
|
||||
"message": "may be mention data type?",
|
||||
"range": {
|
||||
"startLine": 393,
|
||||
"startChar": 39,
|
||||
"endLine": 393,
|
||||
"endChar": 49
|
||||
},
|
||||
"revId": "772f18a2c297646b0d14f86eabf19847ba60e5d0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_e56bd450",
|
||||
|
|
@ -218,6 +356,75 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_21077772",
|
||||
"filename": "sushy_tools/emulator/drivers/libvirtdriver.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 406,
|
||||
"author": {
|
||||
"id": 26340
|
||||
},
|
||||
"writtenOn": "2018-07-21T06:04:22Z",
|
||||
"side": 1,
|
||||
"message": "default encoding seems to be `encoding\u003d\"us-ascii\"`, is it correct that we decode it as `utf-8`?",
|
||||
"range": {
|
||||
"startLine": 406,
|
||||
"startChar": 60,
|
||||
"endLine": 406,
|
||||
"endChar": 67
|
||||
},
|
||||
"revId": "772f18a2c297646b0d14f86eabf19847ba60e5d0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_e1697f25",
|
||||
"filename": "sushy_tools/emulator/drivers/libvirtdriver.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 406,
|
||||
"author": {
|
||||
"id": 26340
|
||||
},
|
||||
"writtenOn": "2018-07-21T06:04:22Z",
|
||||
"side": 1,
|
||||
"message": "do we need to deserialize the XML string from bytes into unicode?",
|
||||
"range": {
|
||||
"startLine": 406,
|
||||
"startChar": 53,
|
||||
"endLine": 406,
|
||||
"endChar": 59
|
||||
},
|
||||
"revId": "772f18a2c297646b0d14f86eabf19847ba60e5d0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_e152df67",
|
||||
"filename": "sushy_tools/emulator/drivers/libvirtdriver.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 420,
|
||||
"author": {
|
||||
"id": 26340
|
||||
},
|
||||
"writtenOn": "2018-07-21T06:04:22Z",
|
||||
"side": 1,
|
||||
"message": "here and elsewhere: may be more explicit that it\u0027s a dict?",
|
||||
"range": {
|
||||
"startLine": 420,
|
||||
"startChar": 18,
|
||||
"endLine": 420,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "772f18a2c297646b0d14f86eabf19847ba60e5d0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_858c602e",
|
||||
|
|
@ -235,6 +442,52 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_81620b3c",
|
||||
"filename": "sushy_tools/emulator/drivers/libvirtdriver.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 443,
|
||||
"author": {
|
||||
"id": 26340
|
||||
},
|
||||
"writtenOn": "2018-07-21T06:04:22Z",
|
||||
"side": 1,
|
||||
"message": "nit: `update\u003dTrue` would be more readable to me",
|
||||
"range": {
|
||||
"startLine": 443,
|
||||
"startChar": 67,
|
||||
"endLine": 443,
|
||||
"endChar": 71
|
||||
},
|
||||
"revId": "772f18a2c297646b0d14f86eabf19847ba60e5d0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_61ed6f8c",
|
||||
"filename": "sushy_tools/emulator/main.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 195,
|
||||
"author": {
|
||||
"id": 26340
|
||||
},
|
||||
"writtenOn": "2018-07-21T06:04:22Z",
|
||||
"side": 1,
|
||||
"message": "may be `indent\u003d2` for readability and `sort\u003d`True` for stability?",
|
||||
"range": {
|
||||
"startLine": 195,
|
||||
"startChar": 37,
|
||||
"endLine": 195,
|
||||
"endChar": 42
|
||||
},
|
||||
"revId": "772f18a2c297646b0d14f86eabf19847ba60e5d0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_05a05090",
|
||||
|
|
|
|||
Loading…
Reference in New Issue