openstack/sushy-tools
Code Issues Proposed changes

Fix Unit test to test for boot index

Browse Source 
This unit test wasn't testing that the boot element was
actually added to the domain xml. Add it.

Change-Id: Iaee2eeb54c650e47877305f17f7d43f609d8065a
This commit is contained in:
Derek Higgins 2021-02-19 15:18:11 +00:00
parent 57d05d944b
commit fb8f3a3924
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sushy_tools/tests/unit/emulator/resources/systems/test_libvirt.py
View File

@ -291,7 +291,8 @@ class LibvirtDriverTestCase(base.BaseTestCase):
'"52:54:00:da:ac:54" />\n <source dev="tap-' \ '"52:54:00:da:ac:54" />\n <source dev="tap-' \
'node-2i1" mode="vepa" />\n <model type="vir' \ 'node-2i1" mode="vepa" />\n <model type="vir' \
'tio" />\n <address bus="0x01" domain="0x' \ 'tio" />\n <address bus="0x01" domain="0x' \
'0000" function="0x0" slot="0x01" type="pci" />' '0000" function="0x0" slot="0x01" type="pci" />\n ' \
'<boot order="1" /></interface>'
# NOTE(rpittau): starting from Python 3.8 the tostring() function # NOTE(rpittau): starting from Python 3.8 the tostring() function
# preserves the attribute order specified by the user. # preserves the attribute order specified by the user.
@ -300,7 +301,8 @@ class LibvirtDriverTestCase(base.BaseTestCase):
'"52:54:00:da:ac:54" />\n <source dev="tap-' \ '"52:54:00:da:ac:54" />\n <source dev="tap-' \
'node-2i1" mode="vepa" />\n <model type="vir' \ 'node-2i1" mode="vepa" />\n <model type="vir' \
'tio" />\n <address type="pci" domain="0x0000" ' \ 'tio" />\n <address type="pci" domain="0x0000" ' \
'bus="0x01" slot="0x01" function="0x0" />' 'bus="0x01" slot="0x01" function="0x0" />\n ' \
'<boot order="1" /></interface>'
self.assertIn(expected, conn_mock.defineXML.call_args[0][0]) self.assertIn(expected, conn_mock.defineXML.call_args[0][0])