openstack/swift
Code Issues Proposed changes

Delay cache invalidation during container creation

Browse Source 
Having the cache being cleared before the PUT request creates a
fairly big window where the cache can be inconsistent, if a concurrent
GET happens. Let's move the cache clear after the requests to reduce it.

Change-Id: I45130cc32ba3a23272c2a67c86b4063000379426
Closes-Bug: #1715177
This commit is contained in:
Thomas Herve
2017-09-05 22:42:32 +02:00
parent 6da17e9923
commit 244d7de388
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
swift/proxy/controllers/container.py
View File

@@ -177,11 +177,11 @@ class ContainerController(Controller):
headers = self._backend_requests(req, len(containers),
account_partition, accounts,
policy_index)
clear_info_cache(self.app, req.environ,
self.account_name, self.container_name)
resp = self.make_requests(
req, self.app.container_ring,
container_partition, 'PUT', req.swift_entity_path, headers)
clear_info_cache(self.app, req.environ,
self.account_name, self.container_name)
return resp
@public