openstack
/
swift
Code Issues Proposed changes

Fix stable gate 

This is a combination of 2 commits.

===

Fix pep8 job

New flake8 came out with new & improved rules. Ignore E741; it would be
too much churn. Fix the rest.

(cherry picked from commit 0fd23ee546)

===

Use ensure-pip role

Hopefully this will fix the currently-broken probe test gate?

Depends-On: https://review.opendev.org/#/c/736070/
(cherry picked from commit 51a587ed8d)

===

Change-Id: I127769c60e99880830a9d891ebc5b9685f74c129
This commit is contained in:
Tim Burke 2020-05-13 00:24:08 -07:00
parent 16f6af9c97
commit 5b1d50866e
5 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/unit/common/test_db.py
View File

@ -1289,7 +1289,7 @@ class TestDatabaseBroker(unittest.TestCase):
for c in range(MAX_META_COUNT): for c in range(MAX_META_COUNT):
key = 'X-Account-Meta-F{0}'.format(c) key = 'X-Account-Meta-F{0}'.format(c)
metadata[key] = ('B', normalize_timestamp(1)) metadata[key] = ('B', normalize_timestamp(1))
key = 'X-Account-Meta-Foo'.format(c) key = 'X-Account-Meta-Foo'
metadata[key] = ('', normalize_timestamp(1)) metadata[key] = ('', normalize_timestamp(1))
self.assertIsNone(DatabaseBroker.validate_metadata(metadata)) self.assertIsNone(DatabaseBroker.validate_metadata(metadata))

3
tools/playbooks/common/install_dependencies.yaml
View File

@ -14,12 +14,13 @@
# limitations under the License. # limitations under the License.
- hosts: all - hosts: all
become: true become: true
roles:
- ensure-pip
tasks: tasks:
- name: installing dependencies - name: installing dependencies
yum: name={{ item }} state=present yum: name={{ item }} state=present
with_items: with_items:
- python-pyeclib - python-pyeclib
- python-pip
- python-nose - python-nose
- python-swiftclient - python-swiftclient

3
tox.ini
View File

@ -131,10 +131,11 @@ commands = bandit -c bandit.yaml -r swift -n 5
# changes to enable: # changes to enable:
# E402: module level import not at top of file # E402: module level import not at top of file
# E731 do not assign a lambda expression, use a def # E731 do not assign a lambda expression, use a def
# E741 ambiguous variable name
# Swift team needs to decide if they want to enable either of these: # Swift team needs to decide if they want to enable either of these:
# W503: line break before binary operator # W503: line break before binary operator
# W504: line break after binary operator # W504: line break after binary operator
ignore = H101,H202,H301,H306,H404,H405,H501,W503,W504,E402,E731 ignore = H101,H202,H301,H306,H404,H405,H501,W503,W504,E402,E731,E741
exclude = .venv,.tox,dist,*egg exclude = .venv,.tox,dist,*egg
filename = *.py,bin/* filename = *.py,bin/*
show-source = True show-source = True