openstack/swift
Code Issues Proposed changes

Only use Timeout if we don't have a final_resp

Browse Source 
I'm sure the Timeout context manager is relatively cheap, but it can't
be free.

Change-Id: I71c0c5944ec372e9b983021dd024de0c5aa1ded2
This commit is contained in:
Tim Burke
2016-06-30 14:32:35 -07:00
committed by Alistair Coles
parent 9045f33869
commit d60662b2eb
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
swift/proxy/controllers/obj.py
View File

@@ -1471,15 +1471,15 @@ class Putter(object):
:returns: HTTPResponse
:raises: Timeout if the response took too long
"""
with Timeout(timeout):
# don't do this update of self.resp if the Expect response during
# conenct() was actually a final response
if not self.final_resp:
# don't do this update of self.resp if the Expect response during
# connect() was actually a final response
if not self.final_resp:
with Timeout(timeout):
if informational:
self.resp = self.conn.getexpect()
else:
self.resp = self.conn.getresponse()
return self.resp
return self.resp
def spawn_sender_greenthread(self, pool, queue_depth, write_timeout,
exception_handler):