openstack
/
swift
Code Issues Proposed changes

swift-init: Don't expose misleading commands 

The kill_child_pids command does NOT need to be an @command to be
available in probe tests.  I don't think it's helpful to operators,
since restarting all children is best handled by existing
reload/seamless-reload commands.  But mainly the seamless option is
misleading since it very much results in a NOT seamless reload (all
workers close sockets immediately, and nothing can accept new
connections until existing connections finish and the parent spawns
replacement workers - i.e. it's just like graceful)

Change-Id: Ic4b274da7dcf9b166513d9c138f4b0370b01eeb0
This commit is contained in:
Clay Gerrard 2020-08-26 12:24:46 -05:00
parent 3f5e712be6
commit ee693265fe
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
swift/common/manager.py
View File

@ -381,7 +381,6 @@ class Manager(object):
status += 1
return status
@command
def kill_child_pids(self, **kwargs):
"""kill child pids, optionally servicing accepted connections"""
status = 0