Tim Burke 32fbf9eaae probe tests: Set default timeout for subprocesses ...

There's an upstream eventlet bug that seems to cause process hangs
during an atexit hook; unfortunately, that means that every time we
call "once" in probe tests, we can hang indefinitely waiting for a
process that won't terminate.

See https://github.com/eventlet/eventlet/issues/989

Now, wait with a timeout; if it pops, kill the offending process and
hope for the best. Do this by patching out subprocess.Popen.wait, but
only in probe tests -- this ensures that we won't impact any real
systems, while also ensuring a broad coverage of probe tests (as
opposed to, say, plumbing some new wait_timeout kwarg into all the
Manager call sites).

Closes-Bug: #2088027
Change-Id: I8983eafbb575d73d1654c354815a7de7ae141873

2024-11-14 10:32:33 -08:00

4.9 KiB

Raw Blame History

View Raw