openstack/tacker
Code Issues Proposed changes

Display missing key name in error message

Browse Source 
This patch will display the key name that is missing in
the parameters while creating the VNF.

Change-Id: I0629fec1be7cba8593c03c11de46f206023b3881
Closes-Bug: #1501858
This commit is contained in:
Bharath Thiruveedula 2015-12-23 19:14:22 +05:30
parent 605b163afb
commit c2791db98b
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tacker/extensions/vnfm.py
View File

@ -86,7 +86,7 @@ class ParamYAMLNotWellFormed(exceptions.InvalidInput):
class InputValuesMissing(exceptions.InvalidInput): class InputValuesMissing(exceptions.InvalidInput):
message = _("Input values missing for 'get_input") message = _("Parameter input values missing for the key '%(key)s'")
class ParamYAMLInputMissing(exceptions.InvalidInput): class ParamYAMLInputMissing(exceptions.InvalidInput):

4
tacker/vm/drivers/heat/heat.py
View File

@ -111,13 +111,13 @@ class DeviceHeat(abstract_driver.DeviceAbstractDriver):
self._update_params(value, paramvalues[key], False) self._update_params(value, paramvalues[key], False)
else: else:
LOG.debug('Key missing Value: %s', key) LOG.debug('Key missing Value: %s', key)
raise vnfm.InputValuesMissing() raise vnfm.InputValuesMissing(key=key)
elif 'get_input' in value: elif 'get_input' in value:
if value['get_input'] in paramvalues: if value['get_input'] in paramvalues:
original[key] = paramvalues[value['get_input']] original[key] = paramvalues[value['get_input']]
else: else:
LOG.debug('Key missing Value: %s', key) LOG.debug('Key missing Value: %s', key)
raise vnfm.InputValuesMissing() raise vnfm.InputValuesMissing(key=key)
else: else:
self._update_params(value, paramvalues, True) self._update_params(value, paramvalues, True)