openstack
/
tempest
Code Issues Proposed changes

Need to have stable implementation of apis 

The implementation of method create_port() varies
between plugins and scenario manager.
This patch addresses the same requirement to make
scenario_manager stable

Implements: blueprint tempest-scenario-manager-stable
Signed-off by: Soniya Vyas<svyas@redhat.com>
Change-Id: Ia743c3a93a0b8e9ffe995db8046047b6e87458c1
This commit is contained in:
Soniya Vyas 2020-09-24 17:43:26 +05:30
parent 60429ddd04
commit 0123f52123
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tempest/scenario/manager.py
View File

@ -143,10 +143,10 @@ class ScenarioTest(tempest.test.BaseTestCase):
# resp part which is not used in scenario tests
def create_port(self, network_id, client=None, **kwargs):
"""Creates port"""
"""Creates port for the respective network_id"""
if not client:
client = self.ports_client
name = data_utils.rand_name(self.__class__.__name__)
name = kwargs.pop('namestart', self.__class__.__name__)
if CONF.network.port_vnic_type and 'binding:vnic_type' not in kwargs:
kwargs['binding:vnic_type'] = CONF.network.port_vnic_type
if CONF.network.port_profile and 'binding:profile' not in kwargs:
@ -155,6 +155,7 @@ class ScenarioTest(tempest.test.BaseTestCase):
name=name,
network_id=network_id,
**kwargs)
self.assertIsNotNone(result, 'Unable to allocate port')
port = result['port']
self.addCleanup(test_utils.call_and_ignore_notfound_exc,
client.delete_port, port['id'])