openstack
/
tempest
Code Issues Proposed changes

Merge "compute: Add negative volume update multiattach test"

This commit is contained in:
Zuul 2020-04-08 19:50:10 +00:00 committed by Gerrit Code Review
parent baecb1e674 4b1085233f
commit 08711d3daa
2 changed files with 65 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
tempest/api/compute/admin/test_volumes_negative.py
View File

@ -13,6 +13,7 @@
# under the License.
from tempest.api.compute import base
from tempest.common import utils
from tempest import config
from tempest.lib.common.utils import data_utils
from tempest.lib import decorators
@ -58,3 +59,66 @@ class VolumesAdminNegativeTest(base.BaseV2ComputeAdminTest):
self.admin_servers_client.update_attached_volume,
self.server['id'], volume['id'],
volumeId=nonexistent_volume)
class UpdateMultiattachVolumeNegativeTest(base.BaseV2ComputeAdminTest):
min_microversion = '2.60'
volume_min_microversion = '3.27'
@classmethod
def skip_checks(self):
super(UpdateMultiattachVolumeNegativeTest, self).skip_checks()
if not CONF.compute_feature_enabled.volume_multiattach:
raise self.skipException('Volume multi-attach is not available.')
@decorators.attr(type=['negative'])
@decorators.idempotent_id('7576d497-b7c6-44bd-9cc5-c5b4e50fec71')
@utils.services('volume')
def test_multiattach_rw_volume_update_failure(self):
# Create two multiattach capable volumes.
vol1 = self.create_volume(multiattach=True)
vol2 = self.create_volume(multiattach=True)
# Create two instances.
server1 = self.create_test_server(wait_until='ACTIVE')
server2 = self.create_test_server(wait_until='ACTIVE')
# Attach vol1 to both of these instances.
vol1_attachment1 = self.attach_volume(server1, vol1)
vol1_attachment2 = self.attach_volume(server2, vol1)
# Assert that we now have two attachments.
vol1 = self.volumes_client.show_volume(vol1['id'])['volume']
self.assertEqual(2, len(vol1['attachments']))
# By default both of these attachments should have an attach_mode of
# read-write, assert that here to ensure the following calls to update
# the volume will be rejected.
for volume_attachment in vol1['attachments']:
attachment_id = volume_attachment['attachment_id']
attachment = self.attachments_client.show_attachment(
attachment_id)['attachment']
self.assertEqual('rw', attachment['attach_mode'])
# Assert that a BadRequest is raised when we attempt to update volume1
# to volume2 on server1 or server2.
self.assertRaises(lib_exc.BadRequest,
self.admin_servers_client.update_attached_volume,
server1['id'], vol1['id'], volumeId=vol2['id'])
self.assertRaises(lib_exc.BadRequest,
self.admin_servers_client.update_attached_volume,
server2['id'], vol1['id'], volumeId=vol2['id'])
# Fetch the volume 1 to check the current attachments.
vol1 = self.volumes_client.show_volume(vol1['id'])['volume']
vol1_attachment_ids = [a['id'] for a in vol1['attachments']]
# Assert that volume 1 is still attached to both server 1 and 2.
self.assertIn(vol1_attachment1['id'], vol1_attachment_ids)
self.assertIn(vol1_attachment2['id'], vol1_attachment_ids)
# Assert that volume 2 has no attachments.
vol2 = self.volumes_client.show_volume(vol2['id'])['volume']
self.assertEqual([], vol2['attachments'])

1
tempest/api/compute/base.py
View File

@ -108,6 +108,7 @@ class BaseV2ComputeTest(api_version_utils.BaseMicroversionTest,
cls.versions_client = cls.os_primary.compute_versions_client
if CONF.service_available.cinder:
cls.volumes_client = cls.os_primary.volumes_client_latest
cls.attachments_client = cls.os_primary.attachments_client_latest
if CONF.service_available.glance:
if CONF.image_feature_enabled.api_v1:
cls.images_client = cls.os_primary.image_client