openstack/tempest
Code Issues Proposed changes

Fix KeyError exc in volumes_client

Browse Source 
is_resource_deleted method of v3 volumes_client was wrongly accessing
id value of a volume causing KeyError - in case the being deleted
volume was in error_deleting state.

Closes-Bug: #1887980
Change-Id: I6cea9917c248ceaa8b7cd60d0a20a2bf7540d9b9
This commit is contained in:
Martin Kopec 2020-07-24 09:35:38 +00:00
parent 50ec7d74c3
commit 14e2a4e421
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
releasenotes/notes/Fix-KeyError-bug-in-v3-volumes_client-ff5d9b894f2257c8.yaml Normal file
View File

@ -0,0 +1,10 @@
---
fixes:
- |
is_resource_deleted method of v3 volumes_client might have returned
a KeyError exception due to an incorrect accessing of a volume id
in the case the volume was in error_deleting state.
incorrect code - volume['id']
correct code - volume['volume']['id']
More details about the issue can be found at
https://bugs.launchpad.net/tempest/+bug/1887980

2
tempest/lib/services/volume/v3/volumes_client.py
View File

@ -219,7 +219,7 @@ class VolumesClient(base_client.BaseClient):
if volume["volume"]["status"] == "error_deleting": if volume["volume"]["status"] == "error_deleting":
raise lib_exc.DeleteErrorException( raise lib_exc.DeleteErrorException(
"Volume %s failed to delete and is in error_deleting status" % "Volume %s failed to delete and is in error_deleting status" %
volume['id']) volume['volume']['id'])
return False return False
@property @property