openstack
/
tempest
Code Issues Proposed changes

Use a smaller number for checking console log length 

Not all images can return console log longer than 10 lines, e.g.,
Red Hat Enterprise Linux Server 7.0 will return console log
with 5 lines.
We don't know how many console log lines should an image return,
but generally speaking it's safer to use a smaller number so that
Tempest can be used for images other than cirros.

Change-Id: I7f6ffe5bdc6b7992fe15935d4f8498e8acf59453
Closes-Bug: #1783509
This commit is contained in:
zhufl 2018-07-25 16:26:21 +08:00
parent 6175b2d3c4
commit 15140ee254
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tempest/api/compute/servers/test_server_actions.py
View File

@ -527,10 +527,10 @@ class ServerActionsTestJSON(base.BaseV2ComputeTest):
def _get_output(self):
output = self.client.get_console_output(
self.server_id, length=10)['output']
self.server_id, length=3)['output']
self.assertTrue(output, "Console output was empty.")
lines = len(output.split('\n'))
self.assertEqual(lines, 10)
self.assertEqual(lines, 3)
@decorators.idempotent_id('4b8867e6-fffa-4d54-b1d1-6fdda57be2f3')
@testtools.skipUnless(CONF.compute_feature_enabled.console_output,
@ -561,8 +561,8 @@ class ServerActionsTestJSON(base.BaseV2ComputeTest):
# NOTE: This test tries to get full length console log, and the
# length should be bigger than the one of test_get_console_output.
self.assertGreater(lines, 10, "Cannot get enough console log "
"length. (lines: %s)" % lines)
self.assertGreater(lines, 3, "Cannot get enough console log "
"length. (lines: %s)" % lines)
self.wait_for(_check_full_length_console_log)