openstack
/
tempest
Code Issues Proposed changes

Use show_quota_class_set after update_quota_class_set 

In test_update_default_quotas, we should use show_quota_class_set
after update_quota_class_set to check whether the quota values
are really changed.
Besides, some LOG messages look odd and maybe being used as comments
are more suitable.

Change-Id: I05e22c88e184df7d425411051c2a8bf846cb35ee
This commit is contained in:
zhufl 2019-04-23 16:41:35 +08:00
parent 8688554660
commit 2b1751e461
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tempest/api/compute/admin/test_quotas.py
View File

@ -212,7 +212,7 @@ class QuotaClassesAdminTestJSON(base.BaseV2ComputeAdminTest):
# 'danger' flag.
@decorators.idempotent_id('7932ab0f-5136-4075-b201-c0e2338df51a')
def test_update_default_quotas(self):
LOG.debug("get the current 'default' quota class values")
# get the current 'default' quota class values
body = (self.adm_client.show_quota_class_set('default')
['quota_class_set'])
self.assertEqual('default', body.pop('id'))
@ -224,9 +224,14 @@ class QuotaClassesAdminTestJSON(base.BaseV2ComputeAdminTest):
# there is a real chance that we go from -1 (unlimited)
# to a very small number which causes issues.
body[quota] = default + 100
LOG.debug("update limits for the default quota class set")
# update limits for the default quota class set
update_body = self.adm_client.update_quota_class_set(
'default', **body)['quota_class_set']
LOG.debug("assert that the response has all of the changed values")
# assert that the response has all of the changed values
self.assertThat(update_body.items(),
matchers.ContainsAll(body.items()))
# check quota values are changed
show_body = self.adm_client.show_quota_class_set(
'default')['quota_class_set']
self.assertThat(show_body.items(),
matchers.ContainsAll(body.items()))