openstack/tempest
Code Issues Proposed changes

Delete meaningless and unused parameters

Browse Source 
Change-Id: I63af79051b6848cf7ed0148bf26b3374f7771fbf
This commit is contained in:
chenpengzi 2018-01-29 11:36:54 +08:00
parent 9139224f2c
commit 2b4bf4b4b3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/check_logs.py
View File

@ -62,7 +62,7 @@ def process_files(file_specs, url_specs, whitelists):
for (name, filename) in file_specs: for (name, filename) in file_specs:
whitelist = whitelists.get(name, []) whitelist = whitelists.get(name, [])
with open(filename) as content: with open(filename) as content:
if scan_content(name, content, regexp, whitelist): if scan_content(content, regexp, whitelist):
logs_with_errors.append(name) logs_with_errors.append(name)
for (name, url) in url_specs: for (name, url) in url_specs:
whitelist = whitelists.get(name, []) whitelist = whitelists.get(name, [])
@ -71,12 +71,12 @@ def process_files(file_specs, url_specs, whitelists):
page = urlreq.urlopen(req) page = urlreq.urlopen(req)
buf = six.StringIO(page.read()) buf = six.StringIO(page.read())
f = gzip.GzipFile(fileobj=buf) f = gzip.GzipFile(fileobj=buf)
if scan_content(name, f.read().splitlines(), regexp, whitelist): if scan_content(f.read().splitlines(), regexp, whitelist):
logs_with_errors.append(name) logs_with_errors.append(name)
return logs_with_errors return logs_with_errors
def scan_content(name, content, regexp, whitelist): def scan_content(content, regexp, whitelist):
had_errors = False had_errors = False
for line in content: for line in content:
if not line.startswith("Stderr:") and regexp.match(line): if not line.startswith("Stderr:") and regexp.match(line):