openstack/tempest
Code Issues Proposed changes

Removing unused attributes from test_run.py

Browse Source 
There is no use of "whitelist_file" and "blacklist_file"
attributes in "_build_regex" method of run.py
These are extra lines in the code of test_run.py
for "whitelist_file" and "blacklist_file".

These attributes were used earlier in "_build_regex" but removed after
I6f5fa7796c576b71c4a0dde66896974a8039a848
But it was missed to remove from test_run.py

This patch will remove the extra lines of code.

Change-Id: I13679de1e8e12bf4c512a76c5dc5058525efda9a
This commit is contained in:
Manik Bindlish 2018-07-26 06:30:09 +00:00
parent b286ad402e
commit 3b26b9f0ef
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tempest/tests/cmd/test_run.py
View File

@ -40,24 +40,18 @@ class TestTempestRun(base.TestCase):
args = mock.Mock(spec=argparse.Namespace)
setattr(args, 'smoke', False)
setattr(args, 'regex', '')
setattr(args, 'whitelist_file', None)
setattr(args, 'blacklist_file', None)
self.assertIsNone(None, self.run_cmd._build_regex(args))
def test__build_regex_smoke(self):
args = mock.Mock(spec=argparse.Namespace)
setattr(args, "smoke", True)
setattr(args, 'regex', '')
setattr(args, 'whitelist_file', None)
setattr(args, 'blacklist_file', None)
self.assertEqual(['smoke'], self.run_cmd._build_regex(args))
def test__build_regex_regex(self):
args = mock.Mock(spec=argparse.Namespace)
setattr(args, 'smoke', False)
setattr(args, "regex", 'i_am_a_fun_little_regex')
setattr(args, 'whitelist_file', None)
setattr(args, 'blacklist_file', None)
self.assertEqual(['i_am_a_fun_little_regex'],
self.run_cmd._build_regex(args))