openstack/tempest
Code Issues Proposed changes

Clarify how to resolve a uuid collision

Browse Source 
Previously 'tox -epep8' just says run 'tox -v -euuidgen' but without
manually removing the duplicate uuid it fails to fix things and says run
'tox -v -euuidgen' again.

Change-Id: I1948c2d038d89af8dcfe69d01dcc49d024ae3210
This commit is contained in:
Joe Gordon 2015-03-27 11:49:57 -04:00
parent f7d582eaa0
commit 4f10e45db7
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/check_uuid.py
View File

@ -275,7 +275,7 @@ class TestChecker(object):
if not test_uuid:
return
if test_uuid in uuids:
error_str = "%s:%s\n uuid %s collision: %s<->%s\n%s:%s\n" % (
error_str = "%s:%s\n uuid %s collision: %s<->%s\n%s:%s" % (
tests[module_name]['source_path'],
tests[module_name]['tests'][test_name].lineno,
test_uuid,
@ -285,6 +285,8 @@ class TestChecker(object):
uuids[test_uuid]['test_node'].lineno,
)
print(error_str)
print("cannot automatically resolve the collision, please "
"manually remove the duplicate value on the new test.")
return True
else:
uuids[test_uuid] = {