openstack/tempest
Code Issues Proposed changes

Remove unnecessary response check in InstanceUsageAuditLogTestJSON

Browse Source 
The response checks in InstanceUsageAuditLogTestJSON are already
covered by schema check, so no need to check it in testcases.

Change-Id: Ia4415d5cd8c3ebc85a5aa72e78e884c6f6f7b48e
This commit is contained in:
zhufl
2018-09-06 17:40:51 +08:00
parent 293e36c61d
commit 6e7c86e119
1 changed files with 2 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tempest/api/compute/admin/test_instance_usage_audit_log.py
View File

@@ -31,27 +31,11 @@ class InstanceUsageAuditLogTestJSON(base.BaseV2ComputeAdminTest):
@decorators.idempotent_id('25319919-33d9-424f-9f99-2c203ee48b9d') @decorators.idempotent_id('25319919-33d9-424f-9f99-2c203ee48b9d')
def test_list_instance_usage_audit_logs(self): def test_list_instance_usage_audit_logs(self):
# list instance usage audit logs # list instance usage audit logs
body = (self.adm_client.list_instance_usage_audit_logs() self.adm_client.list_instance_usage_audit_logs()
["instance_usage_audit_logs"])
expected_items = ['total_errors', 'total_instances', 'log',
'num_hosts_running', 'num_hosts_done',
'num_hosts', 'hosts_not_run', 'overall_status',
'period_ending', 'period_beginning',
'num_hosts_not_run']
for item in expected_items:
self.assertIn(item, body)
@decorators.idempotent_id('6e40459d-7c5f-400b-9e83-449fbc8e7feb') @decorators.idempotent_id('6e40459d-7c5f-400b-9e83-449fbc8e7feb')
def test_get_instance_usage_audit_log(self): def test_get_instance_usage_audit_log(self):
# Get instance usage audit log before specified time # Get instance usage audit log before specified time
now = datetime.datetime.now() now = datetime.datetime.now()
body = (self.adm_client.show_instance_usage_audit_log( self.adm_client.show_instance_usage_audit_log(
urllib.quote(now.strftime("%Y-%m-%d %H:%M:%S"))) urllib.quote(now.strftime("%Y-%m-%d %H:%M:%S")))
["instance_usage_audit_log"])
expected_items = ['total_errors', 'total_instances', 'log',
'num_hosts_running', 'num_hosts_done', 'num_hosts',
'hosts_not_run', 'overall_status', 'period_ending',
'period_beginning', 'num_hosts_not_run']
for item in expected_items:
self.assertIn(item, body)