Merge "Create Flake8 extension for tempest checks"

This commit is contained in:
Jenkins 2013-05-17 12:47:32 +00:00 committed by Gerrit Code Review
commit 75c3409bfe
4 changed files with 45 additions and 0 deletions

tools/ Normal file
View File

View File

tools/hacking/ Normal file
View File

@ -0,0 +1,42 @@
# vim: tabstop=4 shiftwidth=4 softtabstop=4
# Copyright 2013 IBM Corp.
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import re
SKIP_DECORATOR = '@testtools.skip('
def skip_bugs(physical_line):
"""Check skip lines for proper bug entries
T101: Bug not in skip line
T102: Bug in message formatted incorrectly
pos = physical_line.find(SKIP_DECORATOR)
skip_re = re.compile(r'^\s*@testtools.skip.*')
if pos != -1 and skip_re.match(physical_line):
bug = re.compile(r'^.*\bbug\b.*', re.IGNORECASE)
if bug.match(physical_line) is None:
return (pos, 'T101: skips must have an associated bug')
bug_re = re.compile(r'.*skip\(.*Bug\s\#\d+', re.IGNORECASE)
if bug_re.match(physical_line) is None:
return (pos, 'T102: Bug number formatted incorrectly')

View File

@ -54,6 +54,9 @@ commands = flake8
deps = -r{toxinidir}/tools/pip-requires
local-check = tools.hacking.tempest.skip_bugs
ignore = E125,H302,H404
show-source = True