openstack/tempest
Code Issues Proposed changes

Merge "Remove redundant assertIn('id', xxx)"

Browse Source
This commit is contained in:
Jenkins 2016-12-30 05:56:37 +00:00 committed by Gerrit Code Review
commit 7f12f983f3
3 changed files with 0 additions and 6 deletions
tempest/api
image
v1
test_images.py
v2
test_images.py
volume/admin
test_volume_types.py

4
tempest/api/image/v1/test_images.py

@ -54,7 +54,6 @@ class CreateRegisterImagesTest(base.BaseV1ImageTest):
disk_format=disk_format,
is_public=False,
properties=properties)
self.assertIn('id', image)
self.assertEqual('New Name', image.get('name'))
self.assertFalse(image.get('is_public'))
self.assertEqual('queued', image.get('status'))
@ -77,7 +76,6 @@ class CreateRegisterImagesTest(base.BaseV1ImageTest):
location=CONF.image.http_image,
properties={'key1': 'value1',
'key2': 'value2'})
self.assertIn('id', body)
self.assertEqual('New Remote Image', body.get('name'))
self.assertFalse(body.get('is_public'))
self.assertEqual('active', body.get('status'))
@ -92,7 +90,6 @@ class CreateRegisterImagesTest(base.BaseV1ImageTest):
container_format=container_format,
disk_format=disk_format, is_public=False,
copy_from=CONF.image.http_image)
self.assertIn('id', image)
self.assertEqual('New Http Image', image.get('name'))
self.assertFalse(image.get('is_public'))
waiters.wait_for_image_status(self.client, image['id'], 'active')
@ -109,7 +106,6 @@ class CreateRegisterImagesTest(base.BaseV1ImageTest):
is_public=False,
min_ram=40,
properties=properties)
self.assertIn('id', body)
self.assertEqual('New_image_with_min_ram', body.get('name'))
self.assertFalse(body.get('is_public'))
self.assertEqual('queued', body.get('status'))

1
tempest/api/image/v2/test_images.py

@ -49,7 +49,6 @@ class BasicOperationsImagesTest(base.BaseV2ImageTest):
disk_format=disk_format,
visibility='private',
ramdisk_id=uuid)
self.assertIn('id', image)
self.assertIn('name', image)
self.assertEqual(image_name, image['name'])
self.assertIn('visibility', image)

1
tempest/api/volume/admin/test_volume_types.py

@ -93,7 +93,6 @@ class VolumeTypesV2Test(base.BaseVolumeAdminTest):
"vendor_name": vendor}
body = self.create_volume_type(description=description, name=name,
extra_specs=extra_specs)
self.assertIn('id', body)
self.assertIn('name', body)
self.assertEqual(name, body['name'],
"The created volume_type name is not equal "