openstack/tempest
Code Issues Proposed changes

Change containers to list if string

Browse Source 
delete_containers() expects containers should be list, but the method
is used for cleanup and it is easy to miss if a string value is passed
instead of list. This patch changes the method can cover a string case.

Change-Id: Ice9dafa5555e78dc68dc69e82acfd05b894492c1
This commit is contained in:
Ken'ichi Ohmichi 2017-12-21 10:39:13 -08:00 committed by Ghanshyam Mann
parent e3075a1dd7
commit 88cd14961f
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tempest/api/object_storage/base.py
View File

@ -36,10 +36,14 @@ def delete_containers(containers, container_client, object_client):
using HA proxy sync the deletion properly, otherwise, the container using HA proxy sync the deletion properly, otherwise, the container
might fail to be deleted because it's not empty. might fail to be deleted because it's not empty.
:param containers: List of containers to be deleted :param containers: List of containers(or string of a container)
to be deleted
:param container_client: Client to be used to delete containers :param container_client: Client to be used to delete containers
:param object_client: Client to be used to delete objects :param object_client: Client to be used to delete objects
""" """
if isinstance(containers, str):
containers = [containers]
for cont in containers: for cont in containers:
try: try:
params = {'limit': 9999, 'format': 'json'} params = {'limit': 9999, 'format': 'json'}