openstack/tempest
Code Issues Proposed changes

Remove unused return value from take_action

Browse Source 
This commit removes return values from take_action(). Because they are
unused in cliff[1] and to prevent developers misunderstanding.

[1]
http://git.openstack.org/cgit/openstack/cliff/tree/cliff/command.py#n55

Change-Id: I1a81e163acae17005f49decb8cb7ffee52944d26
This commit is contained in:
Masayuki Igawa 2016-06-09 12:28:09 +09:00
parent 7ae7403e47
commit 9262943c56
5 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tempest/cmd/account_generator.py
View File

@ -277,12 +277,11 @@ class TempestAccountGenerator(command.Command):
def take_action(self, parsed_args):
try:
return main(parsed_args)
main(parsed_args)
except Exception:
LOG.exception("Failure generating test accounts.")
traceback.print_exc()
raise
return 0
def get_description(self):
return DESCRIPTION

1
tempest/cmd/cleanup.py
View File

@ -83,7 +83,6 @@ class TempestCleanup(command.Command):
LOG.exception("Failure during cleanup")
traceback.print_exc()
raise
return 0
def init(self, parsed_args):
cleanup_service.init_conf()

1
tempest/cmd/list_plugins.py
View File

@ -30,7 +30,6 @@ LOG = logging.getLogger(__name__)
class TempestListPlugins(command.Command):
def take_action(self, parsed_args):
self._list_plugins()
return 0
def get_description(self):
return 'List all tempest plugins'

1
tempest/cmd/run_stress.py
View File

@ -97,7 +97,6 @@ class TempestRunStress(command.Command):
LOG.exception("Failure in the stress test framework")
traceback.print_exc()
raise
return 0
def get_description(self):
return 'Run tempest stress tests'

3
tempest/cmd/verify_tempest_config.py
View File

@ -418,12 +418,11 @@ class TempestVerifyConfig(command.Command):
def take_action(self, parsed_args):
try:
return main(parsed_args)
main(parsed_args)
except Exception:
LOG.exception("Failure verifying configuration.")
traceback.print_exc()
raise
return 0
if __name__ == "__main__":
main()